From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Scott Jiang <scott.jiang.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
Subject: Re: [PATCH 1/2 v2] asoc: add sport driver for bf6xx soc
Date: Wed, 20 Jun 2012 11:25:55 +0100 [thread overview]
Message-ID: <20120620102555.GI3978@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1340226031-19930-1-git-send-email-scott.jiang.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1024 bytes --]
On Wed, Jun 20, 2012 at 05:00:30PM -0400, Scott Jiang wrote:
Applied, thanks. There is one minor fixup below - please send an
incremental patch for that.
> The SPORT(Serial Port) module on bf6xx soc has a totally different ip comparing to bf5xx
> soc. An individual SPORT module consists of two independently configurable SPORT halves
> with identical functionality. Each SPORT half can be configured for either transmitter
> or receiver.
Please take more care with the formatting of your changelogs, they
should be wrapped to within 80 columns and the subject line should
correspond to the subsystem style. I reflowed.
> +static irqreturn_t sport_err_irq(int irq, void *dev_id)
> +{
> + struct sport_device *sport = dev_id;
> + struct device *dev = &sport->pdev->dev;
> +
> + if (sport->tx_regs->spctl & SPORT_CTL_DERRPRI)
> + dev_dbg(dev, "sport error: TUVF\n");
> + if (sport->rx_regs->spctl & SPORT_CTL_DERRPRI)
> + dev_dbg(dev, "sport error: ROVF\n");
These should be dev_err() not dev_dbg() - they're errors.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 213 bytes --]
_______________________________________________
Uclinux-dist-devel mailing list
Uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org
https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel
next prev parent reply other threads:[~2012-06-20 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 21:00 [PATCH 1/2 v2] asoc: add sport driver for bf6xx soc Scott Jiang
[not found] ` <1340226031-19930-1-git-send-email-scott.jiang.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-06-20 10:25 ` Mark Brown [this message]
2012-06-20 21:00 ` [PATCH 2/2 v2] asoc: add i2s dai " Scott Jiang
2012-06-20 10:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620102555.GI3978@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=scott.jiang.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox