From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Rajeev Kumar <rajeev-dlh.kumar@st.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH V2 3/9] sound:asoc: Add support for synopsys i2s controller as per ASoC framework.
Date: Fri, 22 Jun 2012 10:25:23 +0100 [thread overview]
Message-ID: <20120622092522.GI4037@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <d7aae7f0d84a69e58b2ed22b45b8d93eff05c25e.1340273261.git.rajeev-dlh.kumar@st.com>
[-- Attachment #1.1: Type: text/plain, Size: 630 bytes --]
On Thu, Jun 21, 2012 at 03:54:51PM +0530, Rajeev Kumar wrote:
> This patch add support for synopsys I2S controller as per the ASoC
> framework.
I've applied this but I had to rewrite the subject line.
> +static int dw_i2s_suspend(struct snd_soc_dai *dai)
> +{
> + struct dw_i2s_dev *dev = snd_soc_dai_get_drvdata(dai);
> +
> + clk_disable(dev->clk);
> + return 0;
> +}
It seems a bit sad that we can't disable the clock when the device is
idle. If you need the clock for register I/O then something like the
Tegra approach of using regmap to provide a cached copy of the register
map when the device is idle should work well.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-06-22 9:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 10:24 [PATCH V2 0/9] Add ASoC drivers for SPEAr platform & I2S driver for Designware module Rajeev Kumar
2012-06-21 10:24 ` [PATCH V2 1/9] sound:asoc: Add support for spdif in Audio Codec Rajeev Kumar
2012-06-22 9:21 ` Mark Brown
2012-06-22 9:44 ` Rajeev kumar
2012-06-22 9:49 ` Mark Brown
2012-06-22 9:54 ` Rajeev kumar
2012-06-21 10:24 ` [PATCH V2 2/9] sound:asoc: Add support for STA529 " Rajeev Kumar
2012-06-21 12:25 ` Mark Brown
2012-06-22 6:26 ` Rajeev kumar
2012-06-22 8:49 ` Mark Brown
2012-06-21 10:24 ` [PATCH V2 3/9] sound:asoc: Add support for synopsys i2s controller as per ASoC framework Rajeev Kumar
2012-06-22 9:25 ` Mark Brown [this message]
2012-06-22 9:43 ` Rajeev kumar
2012-06-21 10:24 ` [PATCH V2 4/9] sound:asoc: Add support for SPEAr ASoC pcm layer Rajeev Kumar
2012-06-22 9:28 ` Mark Brown
2012-06-22 9:37 ` Rajeev kumar
2012-06-21 10:24 ` [PATCH V2 5/9] sound:asoc:spdif_in: Add spdif IN support Rajeev Kumar
2012-06-23 10:55 ` Mark Brown
2012-06-21 10:24 ` [PATCH V2 6/9] sound:asoc:spdif_out: Add spdif out support Rajeev Kumar
2012-06-23 10:56 ` Mark Brown
2012-06-21 10:24 ` [PATCH V2 7/9] sound:asoc: Add support for SPEAr ASoC machine driver Rajeev Kumar
2012-06-23 11:01 ` Mark Brown
2012-06-25 10:28 ` Rajeev kumar
2012-06-27 4:37 ` Rajeev kumar
2012-06-27 11:12 ` Mark Brown
2012-06-21 10:24 ` [PATCH V2 8/9] sound:asoc: Add Kconfig and Makefile to support SPEAr audio driver Rajeev Kumar
2012-06-21 10:24 ` [PATCH V2 9/9] sound:asoc: Update Kconfig and Makefile(sound/soc/) to support SPEAr audio Rajeev Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622092522.GI4037@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=rajeev-dlh.kumar@st.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox