Re: [PATCH V2 3/9] sound:asoc: Add support for synopsys i2s controller as per ASoC framework.

[Rajeev kumar <rajeev-dlh.kumar@st.com>]

Hello Mark,

On 6/22/2012 2:55 PM, Mark Brown wrote:
> On Thu, Jun 21, 2012 at 03:54:51PM +0530, Rajeev Kumar wrote:
>> This patch add support for synopsys I2S controller as per the ASoC
>> framework.
>
> I've applied this but I had to rewrite the subject line.
>

Thanks,

>> +static int dw_i2s_suspend(struct snd_soc_dai *dai)
>> +{
>> +	struct dw_i2s_dev *dev = snd_soc_dai_get_drvdata(dai);
>> +
>> +	clk_disable(dev->clk);
>> +	return 0;
>> +}
>
> It seems a bit sad that we can't disable the clock when the device is
> idle.  If you need the clock for register I/O then something like the
> Tegra approach of using regmap to provide a cached copy of the register
> map when the device is idle should work well.

I will keep this in my TODO list and will circulate a separate patch for 
this later.

Best Regards
Rajeev