Re: [PATCH] ASoC: fsl: remove unneeded AUDMUX register setting from imx-sgtl5000

Re: [PATCH] ASoC: fsl: remove unneeded AUDMUX register setting from imx-sgtl5000

[Shawn Guo]

On Wed, Jul 04, 2012 at 03:38:27PM +0800, Hui Wang wrote:
> If we don't set IMX_AUDMUX_V2_PTCR_TCLKDIR in the AUDMUX PTCR
> register (means Tx clock pin is input), we don't need to set
> IMX_AUDMUX_V2_PTCR_TCSEL as well. Since both i.MX35, i.MX51 and
> i.MX6 datasheet says "When Tx clock pin set as an input, the TCSEL
> settings are ignored".
> 
> Signed-off-by: Hui Wang <jason77.wang@gmail.com>

Acked-by: Shawn Guo <shawn.guo@linaro.org>

> ---
>  sound/soc/fsl/imx-sgtl5000.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c
> index 3a729ca..fb21b17 100644
> --- a/sound/soc/fsl/imx-sgtl5000.c
> +++ b/sound/soc/fsl/imx-sgtl5000.c
> @@ -95,8 +95,7 @@ static int __devinit imx_sgtl5000_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  	imx_audmux_v2_configure_port(ext_port,
> -			IMX_AUDMUX_V2_PTCR_SYN |
> -			IMX_AUDMUX_V2_PTCR_TCSEL(int_port),
> +			IMX_AUDMUX_V2_PTCR_SYN,
>  			IMX_AUDMUX_V2_PDCR_RXDSEL(int_port));
>  	if (ret) {
>  		dev_err(&pdev->dev, "audmux external port setup failed\n");
> -- 
> 1.7.6
> 

Re: [PATCH] ASoC: fsl: remove unneeded AUDMUX register setting from imx-sgtl5000

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 363 bytes --]

On Wed, Jul 04, 2012 at 03:38:27PM +0800, Hui Wang wrote:
> If we don't set IMX_AUDMUX_V2_PTCR_TCLKDIR in the AUDMUX PTCR
> register (means Tx clock pin is input), we don't need to set
> IMX_AUDMUX_V2_PTCR_TCSEL as well. Since both i.MX35, i.MX51 and
> i.MX6 datasheet says "When Tx clock pin set as an input, the TCSEL
> settings are ignored".

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]