From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 4/4] ASoC: firmware core: Add core support to create and destroy firmware components.
Date: Wed, 21 Nov 2012 15:49:15 +0900 [thread overview]
Message-ID: <20121121064913.GP4673@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5ha9ubpibs.wl%tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 557 bytes --]
On Wed, Nov 21, 2012 at 07:43:03AM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > Could we make the endianness annotations in the header explicit for now
> > but refuse to handle anything except LE?
> I guess Liam's idea is to check the first 4 magic bytes as endian
> identifier, too ("ASoC" or "CoSA"), and refuse else than native one.
> It would work, but I'm not sure whether this is the best form...
Yeah, and I do think that's OK for the implementation - I'm just
suggesting to mark up the header with the endian correct types from the
get go.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-11-21 6:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 18:12 [PATCH 1/4] ASoC: firmware: Add support for FW based kcontrols Liam Girdwood
2012-11-19 18:12 ` [PATCH 2/4] ASoC: firmware: Add support for FW based widgets Liam Girdwood
2012-11-20 2:16 ` Mark Brown
2012-11-19 18:12 ` [PATCH 3/4] ASoC: firmware core: Add core support for dynamic kcontrols and widgets Liam Girdwood
2012-11-20 2:36 ` Mark Brown
2012-11-20 12:19 ` Liam Girdwood
2012-11-19 18:12 ` [PATCH 4/4] ASoC: firmware core: Add core support to create and destroy firmware components Liam Girdwood
2012-11-19 18:46 ` Takashi Iwai
2012-11-20 12:03 ` Liam Girdwood
2012-11-20 12:05 ` Takashi Iwai
2012-11-21 0:30 ` Mark Brown
2012-11-21 6:43 ` Takashi Iwai
2012-11-21 6:49 ` Mark Brown [this message]
2012-11-20 3:27 ` Mark Brown
2012-11-20 15:14 ` Liam Girdwood
2012-11-21 0:43 ` Mark Brown
2012-11-21 10:21 ` Liam Girdwood
2012-11-21 10:37 ` Mark Brown
2012-11-21 11:16 ` Liam Girdwood
2012-11-21 11:52 ` Mark Brown
2012-11-19 18:36 ` [PATCH 1/4] ASoC: firmware: Add support for FW based kcontrols Takashi Iwai
2012-11-29 12:08 ` Liam Girdwood
2012-11-29 15:15 ` Takashi Iwai
2012-11-29 15:51 ` Liam Girdwood
2012-11-29 16:01 ` Liam Girdwood
2012-11-29 17:35 ` Takashi Iwai
2012-11-29 17:39 ` Liam Girdwood
2012-11-20 2:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121064913.GP4673@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox