From: Liam Girdwood <lrg@ti.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 4/4] ASoC: firmware core: Add core support to create and destroy firmware components.
Date: Tue, 20 Nov 2012 12:03:25 +0000 [thread overview]
Message-ID: <50AB718D.10207@ti.com> (raw)
In-Reply-To: <s5hr4npqvlh.wl%tiwai@suse.de>
On 19/11/12 18:46, Takashi Iwai wrote:
> I find the idea is great. Looking through the patch, a few things
> came to my mind:
>
> - Endianness and alignment
> - Forward-compatibility
> - Avoid the bitfield usages
>
> About endianness: the firmware is usually provided as
> endian-independent. That is, the driver is supposed to convert to CPU
> endianness properly, or check and reject the invalid firmware, at
> least.
>
Yeah, that's something we don't convert atm, but we do check with a u32 magic
number in each header (and will reject that object if the header is missing or
incorrect).
I think we are good with the magic number check atm and I can add some
explicit endianess conversion when we have more users. Atm, the only users
will be ARM based.
Thanks
Liam
next prev parent reply other threads:[~2012-11-20 12:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 18:12 [PATCH 1/4] ASoC: firmware: Add support for FW based kcontrols Liam Girdwood
2012-11-19 18:12 ` [PATCH 2/4] ASoC: firmware: Add support for FW based widgets Liam Girdwood
2012-11-20 2:16 ` Mark Brown
2012-11-19 18:12 ` [PATCH 3/4] ASoC: firmware core: Add core support for dynamic kcontrols and widgets Liam Girdwood
2012-11-20 2:36 ` Mark Brown
2012-11-20 12:19 ` Liam Girdwood
2012-11-19 18:12 ` [PATCH 4/4] ASoC: firmware core: Add core support to create and destroy firmware components Liam Girdwood
2012-11-19 18:46 ` Takashi Iwai
2012-11-20 12:03 ` Liam Girdwood [this message]
2012-11-20 12:05 ` Takashi Iwai
2012-11-21 0:30 ` Mark Brown
2012-11-21 6:43 ` Takashi Iwai
2012-11-21 6:49 ` Mark Brown
2012-11-20 3:27 ` Mark Brown
2012-11-20 15:14 ` Liam Girdwood
2012-11-21 0:43 ` Mark Brown
2012-11-21 10:21 ` Liam Girdwood
2012-11-21 10:37 ` Mark Brown
2012-11-21 11:16 ` Liam Girdwood
2012-11-21 11:52 ` Mark Brown
2012-11-19 18:36 ` [PATCH 1/4] ASoC: firmware: Add support for FW based kcontrols Takashi Iwai
2012-11-29 12:08 ` Liam Girdwood
2012-11-29 15:15 ` Takashi Iwai
2012-11-29 15:51 ` Liam Girdwood
2012-11-29 16:01 ` Liam Girdwood
2012-11-29 17:35 ` Takashi Iwai
2012-11-29 17:39 ` Liam Girdwood
2012-11-20 2:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AB718D.10207@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox