* [PATCH 1/2] ASoC: wm0010: Constify usage of firmware filenames
@ 2013-03-29 9:45 Charles Keepax
2013-03-29 9:45 ` [PATCH 2/2] ASoC: wm0010: Report filename when we fail to load firmware Charles Keepax
2013-03-29 10:52 ` [PATCH 1/2] ASoC: wm0010: Constify usage of firmware filenames Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Charles Keepax @ 2013-03-29 9:45 UTC (permalink / raw)
To: broonie; +Cc: alsa-devel, tiwai, patches, Charles Keepax, lgirdwood
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm0010.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index 40256b5..a5cd51f 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -342,7 +342,7 @@ static void byte_swap_64(u64 *data_in, u64 *data_out, u32 len)
data_out[i] = cpu_to_be64(le64_to_cpu(data_in[i]));
}
-static int wm0010_firmware_load(char *name, struct snd_soc_codec *codec)
+static int wm0010_firmware_load(const char *name, struct snd_soc_codec *codec)
{
struct spi_device *spi = to_spi_device(codec->dev);
struct wm0010_priv *wm0010 = snd_soc_codec_get_drvdata(codec);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] ASoC: wm0010: Report filename when we fail to load firmware
2013-03-29 9:45 [PATCH 1/2] ASoC: wm0010: Constify usage of firmware filenames Charles Keepax
@ 2013-03-29 9:45 ` Charles Keepax
2013-03-29 10:52 ` [PATCH 1/2] ASoC: wm0010: Constify usage of firmware filenames Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2013-03-29 9:45 UTC (permalink / raw)
To: broonie; +Cc: alsa-devel, tiwai, patches, Charles Keepax, lgirdwood
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm0010.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index a5cd51f..a2b2bba 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -361,8 +361,8 @@ static int wm0010_firmware_load(const char *name, struct snd_soc_codec *codec)
ret = request_firmware(&fw, name, codec->dev);
if (ret != 0) {
- dev_err(codec->dev, "Failed to request application: %d\n",
- ret);
+ dev_err(codec->dev, "Failed to request application(%s): %d\n",
+ name, ret);
return ret;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] ASoC: wm0010: Constify usage of firmware filenames
2013-03-29 9:45 [PATCH 1/2] ASoC: wm0010: Constify usage of firmware filenames Charles Keepax
2013-03-29 9:45 ` [PATCH 2/2] ASoC: wm0010: Report filename when we fail to load firmware Charles Keepax
@ 2013-03-29 10:52 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-03-29 10:52 UTC (permalink / raw)
To: Charles Keepax; +Cc: tiwai, alsa-devel, patches, lgirdwood
[-- Attachment #1.1: Type: text/plain, Size: 157 bytes --]
On Fri, Mar 29, 2013 at 09:45:34AM +0000, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Applied both, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-29 10:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-29 9:45 [PATCH 1/2] ASoC: wm0010: Constify usage of firmware filenames Charles Keepax
2013-03-29 9:45 ` [PATCH 2/2] ASoC: wm0010: Report filename when we fail to load firmware Charles Keepax
2013-03-29 10:52 ` [PATCH 1/2] ASoC: wm0010: Constify usage of firmware filenames Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox