From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
tiwai@suse.de, patches@opensource.wolfsonmicro.com,
lgirdwood@gmail.com
Subject: Re: [PATCH 1/3] ALSA: compress_core: Update calc_avail to use cumulative values
Date: Wed, 10 Apr 2013 10:57:02 +0100 [thread overview]
Message-ID: <20130410095702.GA24051@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20130409110230.GE31193@intel.com>
On Tue, Apr 09, 2013 at 04:32:30PM +0530, Vinod Koul wrote:
> On Wed, Apr 03, 2013 at 01:13:27PM +0100, Charles Keepax wrote:
> > The app_pointer is managed locally by the compress core for memory
> > mapped DSPs but for DSPs that are not memory mapped this would have to
> > be manually updated from within the DSP driver itself, which is hardly
> > very idiomatic.
> app pointer means what has been written into DSP buffer, no matter if its memory
> mapped or not. This is updated after .copy returns so if you have been asked to
> copy 100bytes, and return of .copy, app pointer is incremented by 100, so why is
> that not true for you?
Currently though app_pointer is not updated after a copy callback
the cumulative values are updated, but not app_pointer.
app_pointer is only updated in the case were we don't have a copy
callback and the buffer is managed by the compressed core.
I am quite happy to change that or remove this comment from the change
log if we prefer but as it currently stands app_pointer will not
be updated for systems that use a copy callback by the compress
core.
Charles
next prev parent reply other threads:[~2013-04-10 10:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 12:13 [PATCH 1/3] ALSA: compress_core: Update calc_avail to use cumulative values Charles Keepax
2013-04-03 12:13 ` [PATCH 2/3] ALSA: compress_core: Split copy into seperate read and write callbacks Charles Keepax
2013-04-04 18:01 ` Pierre-Louis Bossart
2013-04-05 8:23 ` Charles Keepax
2013-04-09 11:15 ` Vinod Koul
2013-04-09 11:47 ` Mark Brown
2013-04-09 14:30 ` Takashi Iwai
2013-04-03 12:13 ` [PATCH 3/3] ASoC: soc-compress: " Charles Keepax
2013-04-09 11:15 ` Vinod Koul
2013-04-04 18:22 ` [PATCH 1/3] ALSA: compress_core: Update calc_avail to use cumulative values Pierre-Louis Bossart
2013-04-05 8:36 ` Charles Keepax
2013-04-05 14:51 ` Pierre-Louis Bossart
2013-04-05 15:18 ` Charles Keepax
2013-04-09 10:55 ` Vinod Koul
2013-04-10 3:59 ` Pierre-Louis Bossart
2013-04-10 10:01 ` Charles Keepax
2013-04-09 11:02 ` Vinod Koul
2013-04-10 9:57 ` Charles Keepax [this message]
2013-04-10 10:07 ` Charles Keepax
2013-04-10 13:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410095702.GA24051@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox