Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
	tiwai@suse.de, patches@opensource.wolfsonmicro.com,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.jf.intel.com>,
	lgirdwood@gmail.com,
	Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/3] ALSA: compress_core: Update calc_avail to use cumulative values
Date: Tue, 09 Apr 2013 20:59:48 -0700	[thread overview]
Message-ID: <5164E3B4.5050900@linux.intel.com> (raw)
In-Reply-To: <20130409105505.GD31193@intel.com>


> we can normally use offsets to work and do all the calculation in the core. But
> this check fails when app_ptr = hw_ptr. Here we dont know if the buffer is full
> or empty :) So we need to look at cummulative values for those checks, hence the
> core maintains both of these and IIRC looks at cummulative values when
> calucating avail only when we hit the above condition or probably in case when
> we wrap over the ring buffer.
>
> In both memory mapped and non mapped these cases are true so I dont see why this
> caluclation is specfic for memory maped DSPs. There is nothing in this case
> which relies. We only use the values reported by DSP and internal counters...

the question was whether we need these offsets at all. Can't we just use 
cumulative values everywhere?
-Pierre

  reply	other threads:[~2013-04-10  3:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 12:13 [PATCH 1/3] ALSA: compress_core: Update calc_avail to use cumulative values Charles Keepax
2013-04-03 12:13 ` [PATCH 2/3] ALSA: compress_core: Split copy into seperate read and write callbacks Charles Keepax
2013-04-04 18:01   ` Pierre-Louis Bossart
2013-04-05  8:23     ` Charles Keepax
2013-04-09 11:15       ` Vinod Koul
2013-04-09 11:47         ` Mark Brown
2013-04-09 14:30           ` Takashi Iwai
2013-04-03 12:13 ` [PATCH 3/3] ASoC: soc-compress: " Charles Keepax
2013-04-09 11:15   ` Vinod Koul
2013-04-04 18:22 ` [PATCH 1/3] ALSA: compress_core: Update calc_avail to use cumulative values Pierre-Louis Bossart
2013-04-05  8:36   ` Charles Keepax
2013-04-05 14:51     ` Pierre-Louis Bossart
2013-04-05 15:18       ` Charles Keepax
2013-04-09 10:55         ` Vinod Koul
2013-04-10  3:59           ` Pierre-Louis Bossart [this message]
2013-04-10 10:01             ` Charles Keepax
2013-04-09 11:02 ` Vinod Koul
2013-04-10  9:57   ` Charles Keepax
2013-04-10 10:07   ` Charles Keepax
2013-04-10 13:03     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5164E3B4.5050900@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=pierre-louis.bossart@linux.jf.intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox