Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: McASP: Fix receive clock polarity in DAIFMT_NB_NF mode.
@ 2013-05-03  5:37 Marek Belisko
  2013-05-03  8:30 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Marek Belisko @ 2013-05-03  5:37 UTC (permalink / raw)
  To: lgirdwood, broonie, perex, tiwai
  Cc: zonque, alsa-devel, linux-kernel, Marek Belisko

According documentation bit ACLKRPOL is set to 0 (receiver samples data
on falling edge) and when set to 1 (receiver samples data on rising edge).

I2S data are always sampled on falling edge and valid during rising edge
of bit clock. So in case of capture data transmitter sample data on falling
edge and macsp must read then on rising edge.

Signed-off-by: Marek Belisko <marek.belisko@streamunlimited.com>
---
 sound/soc/davinci/davinci-mcasp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index 849a187..c46112e 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -568,7 +568,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
 		mcasp_set_bits(base + DAVINCI_MCASP_ACLKXCTL_REG, ACLKXPOL);
 		mcasp_clr_bits(base + DAVINCI_MCASP_TXFMCTL_REG, FSXPOL);
 
-		mcasp_clr_bits(base + DAVINCI_MCASP_ACLKRCTL_REG, ACLKRPOL);
+		mcasp_set_bits(base + DAVINCI_MCASP_ACLKRCTL_REG, ACLKRPOL);
 		mcasp_clr_bits(base + DAVINCI_MCASP_RXFMCTL_REG, FSRPOL);
 		break;
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: McASP: Fix receive clock polarity in DAIFMT_NB_NF mode.
  2013-05-03  5:37 [PATCH] ASoC: McASP: Fix receive clock polarity in DAIFMT_NB_NF mode Marek Belisko
@ 2013-05-03  8:30 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-05-03  8:30 UTC (permalink / raw)
  To: Marek Belisko
  Cc: alsa-devel, lgirdwood, tiwai, linux-kernel, zonque, Marek Belisko


[-- Attachment #1.1: Type: text/plain, Size: 232 bytes --]

On Fri, May 03, 2013 at 07:37:36AM +0200, Marek Belisko wrote:
> According documentation bit ACLKRPOL is set to 0 (receiver samples data
> on falling edge) and when set to 1 (receiver samples data on rising edge).

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-03  8:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-03  5:37 [PATCH] ASoC: McASP: Fix receive clock polarity in DAIFMT_NB_NF mode Marek Belisko
2013-05-03  8:30 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox