Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

[Fabio Baltieri <fabio.baltieri@linaro.org>]

On Wed, May 08, 2013 at 04:17:23PM +0200, Fabio Baltieri wrote:
> > > If I understood the problem correctly you do that when you want to cut
> > > power completely to some peripherals to avoid spurious current paths,
> > > and that should not be the case for the audio codec, especially in this
> > > case where it's part of a big multifuntion IC.
> > 
> > Being a MFD should have nothing to do with this?
> 
> Ok, what I'm trying to say is that the codec used in this platform
> should be able to handle sleep modes without requiring any
> reconfiguration of the digital interface on the SoC side.  In support of
> this the fact that the STE fork of the driver does not do that, and the
> same goes for all other ASoC drivers currently in mainline.

And by the way, if the current code is *really* setting the digital
audio bus pins in hi-z mode (without any pull-up/down/keeper) as it
claims, this is not just usless, it's plain wrong.  The bus should never
be left floating on both sides, right?

Fabio

-- 
Fabio Baltieri