From: Mark Brown <broonie@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
matt@genesi-usa.com, alsa-devel@alsa-project.org,
eric.nelson@boundarydevices.com, troy.kisky@boundarydevices.com
Subject: Re: [PATCH] ASoC: sgtl5000: Fix driver probe after reset
Date: Thu, 9 May 2013 10:30:46 +0100 [thread overview]
Message-ID: <20130509093046.GY7478@sirena.org.uk> (raw)
In-Reply-To: <1368032653-19489-1-git-send-email-festevam@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 608 bytes --]
On Wed, May 08, 2013 at 02:04:06PM -0300, Fabio Estevam wrote:
> As the sgtl5000 codec did not go through a real reset, we cannot rely on the
> reg_defaults array, since these are only valid after a clean power-on reset.
> To fix this issue, use 'reg_defaults_raw' which tells the regcache driver
> to actually read the codec registers and then fill the cache.
No, this isn't what raw defaults are for - they're for cases where the
power on defaults can be changed (eg, by setting pins on the board).
If we do this cases where we rely on defaults actually being chip
defaults can get broken.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2013-05-09 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 17:04 [PATCH] ASoC: sgtl5000: Fix driver probe after reset Fabio Estevam
2013-05-08 20:12 ` Lars-Peter Clausen
2013-05-09 9:30 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509093046.GY7478@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=eric.nelson@boundarydevices.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=matt@genesi-usa.com \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox