Re: [PATCH] ASoC: dapm: check suspend state in dapm_dai_check_power()

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1040 bytes --]

On Mon, Jun 03, 2013 at 11:36:40AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> Currently, when the system enters suspend with audio playing, since the
> DAI widgets are active, the associated CODEC is considered active, and
> hence is not transition into a low-power bias state as the system
> suspends. This likely causes audio failure after resume, since the CODEC
> power has quite possibly been removed during suspend, and the bias level
> transitions in the CODEC driver are needed to recover from this. At the
> very least, this issue likely causes warnings in the kernel log due to
> the CODEC being left on over the suspend transition.
> 
> To solve this, modify dapm_dai_check_power() not to consider DAI widgets
> active if the system is entering suspend.

I would expect us to be dealing with this as part of quiescing the DMA
operations on the links - it's not just the CODEC that needs handling
here.  This feels like it ought to be more joined up somewhere along the
line.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]