From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Stephen Warren <swarren@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH] ASoC: dapm: check suspend state in dapm_dai_check_power()
Date: Mon, 3 Jun 2013 20:46:28 +0100 [thread overview]
Message-ID: <20130603194628.GV31367@sirena.org.uk> (raw)
In-Reply-To: <51ACEB94.9020205@metafoo.de>
[-- Attachment #1.1: Type: text/plain, Size: 557 bytes --]
On Mon, Jun 03, 2013 at 09:16:36PM +0200, Lars-Peter Clausen wrote:
> I think it is just an oversight that this is not working properly right now.
> In snd_soc_suspend() where we also stop the DMA streams etc the DAI link
> widgets are put into suspend, by calling snd_soc_dapm_stream_event(...,
> SND_SOC_DAPM_STREAM_SUSPEND). But dapm_dai_check_power() doesn't consider
> this and hence stays active and also keeps the whole DAPM context (this is
> not CODEC specific) active.
It's clearly an oversight but I don't think this is a joined up fix for
it.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-06-03 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 17:36 [PATCH] ASoC: dapm: check suspend state in dapm_dai_check_power() Stephen Warren
2013-06-03 18:51 ` Mark Brown
2013-06-03 19:16 ` Lars-Peter Clausen
2013-06-03 19:46 ` Mark Brown [this message]
2013-06-03 19:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603194628.GV31367@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox