From: Mark Brown <broonie@kernel.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: si476x: Remove custom register I/O implementation
Date: Fri, 27 Sep 2013 11:07:57 +0100 [thread overview]
Message-ID: <20130927100757.GA19304@sirena.org.uk> (raw)
In-Reply-To: <CAHQ1cqFUNVsKAdimFooyraK3vpvZP=asxAimjzhyyD8T1YRP=Q@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 726 bytes --]
On Thu, Sep 26, 2013 at 03:48:09PM -0700, Andrey Smirnov wrote:
> On Thu, Sep 26, 2013 at 1:58 PM, Mark Brown <broonie@kernel.org> wrote:
> > In what way might these things conflict? What are the clashes you are
> > concerned about?
> That lock serves the purpose of making sure that
> si476x_core_send_command, calls to which all the rest of the functions
> boil down to, is not executed in parallel to itself. So I am concerned
> that with the lock acquisition removal it would be possible to make
> that condition happen.
OK, so if it's purely about send_command() then why is the locking not
being done in that function? Surely the most obvious and robust place
to protect the function is within the function itself?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-09-27 10:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 18:34 [PATCH] ASoC: si476x: Remove custom register I/O implementation Mark Brown
2013-09-26 19:33 ` Andrey Smirnov
2013-09-26 19:43 ` Mark Brown
2013-09-26 19:58 ` Andrey Smirnov
2013-09-26 20:58 ` Mark Brown
2013-09-26 22:48 ` Andrey Smirnov
2013-09-27 10:07 ` Mark Brown [this message]
2013-09-27 15:53 ` Andrey Smirnov
2013-09-27 17:02 ` Mark Brown
2013-09-27 19:28 ` Andrey Smirnov
2013-09-27 19:48 ` Mark Brown
2013-09-28 4:37 ` Andrey Smirnov
2013-09-28 11:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927100757.GA19304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andrew.smirnov@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox