From: Mark Brown <broonie@kernel.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: si476x: Remove custom register I/O implementation
Date: Sat, 28 Sep 2013 12:53:46 +0100 [thread overview]
Message-ID: <20130928115346.GP19304@sirena.org.uk> (raw)
In-Reply-To: <CAHQ1cqEeHa+JbDZ8S0ySztRpe09zL1r9BYstyu+unzMn5UeymA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 690 bytes --]
On Fri, Sep 27, 2013 at 09:37:01PM -0700, Andrey Smirnov wrote:
> > Since the driver doesn't expose any controls to userspace the only
> > things that can cause register writes are the operations provided by the
> > CODEC driver, they could take the lock for their runtime (which is about
> > the level the v4l stuff is running at AIUI).
> Do you mean moving it to si476x_codec_set_dai_fmt and
> si476x_codec_hw_params? If those are the only two places where
> register read and write are called by SoC sound subsystem then I think
> that would work.
Yes, exactly. Unless you provide controls or DAPM nothing outside of
the callbacks in your driver is going to interact with registers.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2013-09-28 11:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 18:34 [PATCH] ASoC: si476x: Remove custom register I/O implementation Mark Brown
2013-09-26 19:33 ` Andrey Smirnov
2013-09-26 19:43 ` Mark Brown
2013-09-26 19:58 ` Andrey Smirnov
2013-09-26 20:58 ` Mark Brown
2013-09-26 22:48 ` Andrey Smirnov
2013-09-27 10:07 ` Mark Brown
2013-09-27 15:53 ` Andrey Smirnov
2013-09-27 17:02 ` Mark Brown
2013-09-27 19:28 ` Andrey Smirnov
2013-09-27 19:48 ` Mark Brown
2013-09-28 4:37 ` Andrey Smirnov
2013-09-28 11:53 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130928115346.GP19304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andrew.smirnov@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox