Re: [PATCH v3 2/2] ASoC: kirkwood: fix loss of external clock at probe time

From: Mark Brown <broonie@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Jean-Francois Moine <moinejf@free.fr>,
	alsa-devel@alsa-project.org, Jason Cooper <jason@lakedaemon.net>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v3 2/2] ASoC: kirkwood: fix loss of external clock at probe time
Date: Sun, 20 Oct 2013 17:33:26 +0100	[thread overview]
Message-ID: <20131020163326.GN2443@sirena.org.uk> (raw)
In-Reply-To: <20131020080333.GG10079@pengutronix.de>

[-- Attachment #1.1: Type: text/plain, Size: 673 bytes --]

On Sun, Oct 20, 2013 at 10:03:33AM +0200, Uwe Kleine-König wrote:

> Yes, that's understood. My suggestion behaves as your's for the return
> values -EPROBE_DEFER and -ENOENT, so the deferred probe should work,
> too. The question is only what you want to do for other errors (don't
> know if they can happen at this stage). I'd say, on a dt parsing error
> bail out, too.

It seems like the best thing to do is defer if the error might resolve
itself but otherwise carry on with the reduced functionality from the
internal clocks.  I'd expect most errors to be permanently fatal though,
certainly a failure to parse the DT is unlikely to get fixed at runtime.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel