From: Mark Brown <broonie@kernel.org>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
alsa-devel@alsa-project.org,
"Jason Cooper" <jason@lakedaemon.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Russell King" <rmk+kernel@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v3 2/2] ASoC: kirkwood: fix loss of external clock at probe time
Date: Sun, 20 Oct 2013 17:38:19 +0100 [thread overview]
Message-ID: <20131020163819.GO2443@sirena.org.uk> (raw)
In-Reply-To: <20131018203555.4d974251@armhf>
[-- Attachment #1.1: Type: text/plain, Size: 615 bytes --]
On Fri, Oct 18, 2013 at 08:35:55PM +0200, Jean-Francois Moine wrote:
> At probe time, when the clock driver is not yet initialized, the
> external clock of the kirkwood sound device will not be usable.
This doesn't apply against -next, could you please check and resend?
git://git.kernel.org/pub/scm/linux/kernel/git/broone/sound.git topic/kirkwood
or the for-next branch.
> It also removes the test about same internal and external clocks which
> can never occur.
It seems like reasonable defensiveness to have the test there in case
someone has a broken DT, though it'd be better to complain about the DT.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-10-20 16:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 18:35 [PATCH v3 2/2] ASoC: kirkwood: fix loss of external clock at probe time Jean-Francois Moine
2013-10-18 19:12 ` Uwe Kleine-König
2013-10-19 8:28 ` Jean-Francois Moine
2013-10-20 8:03 ` Uwe Kleine-König
2013-10-20 16:33 ` Mark Brown
2013-10-20 16:38 ` Mark Brown [this message]
2013-10-21 7:24 ` Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131020163819.GO2443@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=moinejf@free.fr \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox