From: Mark Brown <broonie@kernel.org>
To: Daniel Mack <zonque@gmail.com>
Cc: brian.austin@cirrus.com, subaparts@yandex.ru,
alsa-devel@alsa-project.org, Paul.Handrigan@cirrus.com
Subject: Re: [PATCH] ASoC: cs4271: free reset gpio in cs4271_remove()
Date: Wed, 19 Feb 2014 20:15:29 +0900 [thread overview]
Message-ID: <20140219111529.GI2669@sirena.org.uk> (raw)
In-Reply-To: <1392808032-25756-1-git-send-email-zonque@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]
On Wed, Feb 19, 2014 at 12:07:12PM +0100, Daniel Mack wrote:
> + if (gpio_is_valid(cs4271->gpio_nreset)) {
> /* Set codec to the reset state */
> gpio_set_value(cs4271->gpio_nreset, 0);
> + devm_gpio_free(codec->dev, cs4271->gpio_nreset);
> + }
If it's being requested as a managed resource shouldn't it be being
freed automatically?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-02-19 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 11:07 [PATCH] ASoC: cs4271: free reset gpio in cs4271_remove() Daniel Mack
2014-02-19 11:15 ` Mark Brown [this message]
2014-02-19 11:24 ` Daniel Mack
2014-02-19 11:43 ` Mark Brown
2014-02-19 12:09 ` Daniel Mack
2014-02-19 14:00 ` Mark Brown
2014-02-19 11:43 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219111529.GI2669@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=subaparts@yandex.ru \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox