Re: [PATCH] ASoC: cs4271: free reset gpio in cs4271_remove()

[Daniel Mack <daniel@zonque.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/19/2014 12:43 PM, Mark Brown wrote:
> On Wed, Feb 19, 2014 at 12:24:23PM +0100, Daniel Mack wrote:
>> On 02/19/2014 12:15 PM, Mark Brown wrote:
>>> On Wed, Feb 19, 2014 at 12:07:12PM +0100, Daniel Mack wrote:
> 
>>>> +	if (gpio_is_valid(cs4271->gpio_nreset)) { /* Set codec to
>>>> the reset state */ gpio_set_value(cs4271->gpio_nreset, 0); +
>>>> devm_gpio_free(codec->dev, cs4271->gpio_nreset); +	}
> 
>>> If it's being requested as a managed resource shouldn't it be
>>> being freed automatically?
> 
>> Nope, as the module itself will not go away necessarily. I hit
>> the bug when unloading and reloading the machine driver.
>> cs4271_probe(codec) will fail to acquire and drive the reset
>> line, and the codec stays in reset.
> 
> The fix here is to move the resource acquisition to the bus level
> probe instead of the ASoC card startup.
> 

Alright. I thought there was a verdict once that resource claiming
should be done right before usage, but you're right, it really rather
belongs into the bus probe functions.

I'll send another version.


Thanks!
Daniel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTBJ72AAoJELphMRr8Y1QkXt8P/RErTL26/X3s/MnYfhuPDzsx
T7oU/YSpYvcqBVBab3rZjbyELRPqcrWO0XaiVFLiOqwt2KslKK/k8zz8gZIsvOxM
YzheQMzI45sosYCFf1OssC7ojwTTks/hwgKzOj0Hi0aWtSVYRgV2kvg8S4tiwEzl
OpM9Z4r0lCw9kJidlSwPCXcg+s4BN6xMcqaTIFfU1QCQ84dxHwzhf7cYZliOtWEv
FlnMVKYAtBVCACVqBxHS+2OdopcTuwQ0aqts7UMXFq2MGCIYf6Fyq/qmmCMuaZrN
yDcm3fpJodIoZo20nIf2zpaPGgD7ce+LK/Mu46sZ4MFRBxHgGlQ0C2UNZgNlVILI
mY6hj8s44kCptX1sDPTviYoRnxQ4PTAdRUjfVRuShjkEFi8WHKEbIHwLqn0BvjSB
FaaESTg5NhBJsAroTK83nqqY7MxcLZV4YBhnoH4Mhc2IZHa5hOxcHy5crGyUUEGF
4QWMJoHW+J3s8malsvwcNj8Fv4a6SaeptNr+4EkGW/lwrVAjl/03Ei7MvvqApyPm
TSRuBXQUbiJhxBpkAMhFQ7jIj3Gw+CcgiudcwLA1sVdN2uTvbe/YRas/ZlWQn/W9
TVihbfTM8apHwCacyJYX7yE16eJ162AznYqCZC5ZCJ1L2k8ep30bhwEJk2nq4GP1
6FikGJ1wGOLdvDbwOc8b
=dthk
-----END PGP SIGNATURE-----