From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Intel: Make sure we only build SST drivers on X86
Date: Thu, 20 Feb 2014 00:57:58 +0900 [thread overview]
Message-ID: <20140219155758.GK2669@sirena.org.uk> (raw)
In-Reply-To: <s5h1tyzw2la.wl%tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 831 bytes --]
On Wed, Feb 19, 2014 at 04:21:05PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > But lots of architectures do actually have these operations, I suspect
> > looking at some of the existing users depending on PCI is enough if
> > excessively strict (this will improve build coverage which tends to be
> > useful even if the driver can't be run).
> Yes. I guess including linux/io.h should fix the build issue.
It should for PowerPC (and ought to be done anyway since an implicit
include is going to break eventually on x86 too) but it won't for
architectures that don't have the function at all.
> Though, limiting the build to X86 isn't bad particularly for this
> driver.
Most people working on ASoC don't build x86 that often, more build
coverage of these minority platforms is going to help avoid issues for
-next! :)
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-02-19 15:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 14:06 [PATCHv2] ASoC: Intel: Fix sparse warnings for firmware loader Liam Girdwood
2014-02-19 14:06 ` [PATCH] ASoC: Intel: Make sure we only build SST drivers on X86 Liam Girdwood
2014-02-19 15:00 ` Mark Brown
2014-02-19 15:21 ` Takashi Iwai
2014-02-19 15:57 ` Mark Brown [this message]
2014-02-19 16:15 ` Takashi Iwai
2014-02-19 16:22 ` Mark Brown
2014-02-19 15:24 ` Liam Girdwood
2014-02-19 16:02 ` Mark Brown
2014-02-19 15:09 ` [PATCHv2] ASoC: Intel: Fix sparse warnings for firmware loader Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219155758.GK2669@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox