From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Intel: Make sure we only build SST drivers on X86
Date: Wed, 19 Feb 2014 16:21:05 +0100 [thread overview]
Message-ID: <s5h1tyzw2la.wl%tiwai@suse.de> (raw)
In-Reply-To: <20140219150040.GD2669@sirena.org.uk>
At Thu, 20 Feb 2014 00:00:40 +0900,
Mark Brown wrote:
>
> On Wed, Feb 19, 2014 at 02:06:24PM +0000, Liam Girdwood wrote:
> > Disable build on non X86 architectures. This fixes the following build
> > errors on PPC :-
>
> > sound/soc/intel/sst-dsp.c: In function 'sst_dsp_outbox_write':
> > sound/soc/intel/sst-dsp.c:218:2: error: implicit declaration of function 'memcpy_toio' [-Werror=implicit-function-declaration]
> > memcpy_toio(sst->mailbox.out_base, message, bytes);
> > ^
>
> But lots of architectures do actually have these operations, I suspect
> looking at some of the existing users depending on PCI is enough if
> excessively strict (this will improve build coverage which tends to be
> useful even if the driver can't be run).
Yes. I guess including linux/io.h should fix the build issue.
Though, limiting the build to X86 isn't bad particularly for this
driver.
Takashi
next prev parent reply other threads:[~2014-02-19 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 14:06 [PATCHv2] ASoC: Intel: Fix sparse warnings for firmware loader Liam Girdwood
2014-02-19 14:06 ` [PATCH] ASoC: Intel: Make sure we only build SST drivers on X86 Liam Girdwood
2014-02-19 15:00 ` Mark Brown
2014-02-19 15:21 ` Takashi Iwai [this message]
2014-02-19 15:57 ` Mark Brown
2014-02-19 16:15 ` Takashi Iwai
2014-02-19 16:22 ` Mark Brown
2014-02-19 15:24 ` Liam Girdwood
2014-02-19 16:02 ` Mark Brown
2014-02-19 15:09 ` [PATCHv2] ASoC: Intel: Fix sparse warnings for firmware loader Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1tyzw2la.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox