From: Mark Brown <broonie@kernel.org>
To: Rongjun Ying <Rongjun.Ying@csr.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
DL-SHA-WorkGroupLinux <DL-SHA-WorkGroupLinux@internal.csr.com>,
Liam Girdwood <lgirdwood@gmail.com>,
RongJun Ying <rjying@gmail.com>
Subject: Re: [PATCH v4-resend 1/7] ASoC: sirf: Add SiRF internal audio codec driver
Date: Mon, 3 Mar 2014 13:07:45 +0800 [thread overview]
Message-ID: <20140303050745.GP2411@sirena.org.uk> (raw)
In-Reply-To: <86130EF012BDF348AA0D464A4F449478012AE52440@SHAASIEXM01.ASIA.ROOT.PRI>
[-- Attachment #1.1: Type: text/plain, Size: 387 bytes --]
On Mon, Mar 03, 2014 at 02:15:17AM +0000, Rongjun Ying wrote:
> The codec clock is only used by this driver. And this clock is not managed by
> clock controller. The Audio controller codec is always enable. So I think
> it is not need abstract to general clock API.
No, you're still missing the point. You are requesting external clocks,
why are you not managing those here?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-03-03 5:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 7:22 [PATCH v4-resend 0/7] ASoC: add CSR SiRFSoC sound drivers RongJun Ying
2014-02-26 7:22 ` [PATCH v4-resend 1/7] ASoC: sirf: Add SiRF internal audio codec driver RongJun Ying
2014-02-27 5:33 ` Mark Brown
2014-02-28 1:52 ` Rongjun Ying
2014-03-01 3:16 ` Mark Brown
2014-03-03 2:15 ` Rongjun Ying
2014-03-03 5:07 ` Mark Brown [this message]
2014-03-03 7:48 ` Barry Song
2014-03-04 4:58 ` Mark Brown
2014-03-04 5:11 ` RongJun Ying
2014-03-05 3:34 ` Mark Brown
2014-03-05 5:34 ` RongJun Ying
2014-02-26 7:22 ` [PATCH v4-resend 2/7] ASoC: sirf: Add SiRF audio port driver is used by SiRF internal audio codec RongJun Ying
2014-03-01 4:49 ` Mark Brown
2014-02-26 7:22 ` [PATCH v4-resend 3/7] ASoC: sirf: Add SiRF audio card RongJun Ying
2014-02-26 7:22 ` [PATCH v4-resend 4/7] ASoC: sirf: Add SiRF I2S driver RongJun Ying
2014-02-26 7:22 ` [PATCH v4-resend 5/7] ASoC: sirf: Add hdmi card RongJun Ying
2014-02-26 7:22 ` [PATCH v4-resend 6/7] ASoC: sirf: Add usp driver which is used by dsp mode RongJun Ying
2014-02-26 7:22 ` [PATCH v4-resend 7/7] ASoC: sirf: Add bt-sco card RongJun Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303050745.GP2411@sirena.org.uk \
--to=broonie@kernel.org \
--cc=DL-SHA-WorkGroupLinux@internal.csr.com \
--cc=Rongjun.Ying@csr.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=rjying@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox