Re: [PATCH v4-resend 1/7] ASoC: sirf: Add SiRF internal audio codec driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1110 bytes --]

On Tue, Mar 04, 2014 at 01:11:50PM +0800, RongJun Ying wrote:
> 2014-03-04 12:58 GMT+08:00 Mark Brown <broonie@kernel.org>:
> > On Mon, Mar 03, 2014 at 03:48:02PM +0800, Barry Song wrote:

> >> here the clock is an internal clock in the internal codec. the
> >> external clock of audio controller is managed in system suspend/resume
> >> as you see. but they are not managed in runtime suspend/resume here
> >> because the external clock is always enabled to make sure the charge
> >> pump to be working to make the board have stable current and voltage.
> >> otherwise, touchscreen ADC will not be accurate.

> > Why aren't these drivers keeping the clock enabled themselves?

> The charge pump register is a part of  the audio controller.
> But this register is impacted the touchscreen ADC stable.
> So when the audio codec driver probe, It always enable the audio
> controller's clock,
> and must be set the charge pump register.

I'm sorry but I just can't follow what you're talking about at all.  In
one mail above you were talking about an external clock but here you're
talking about the charge pump.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]