From: Mark Brown <broonie@kernel.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: linux-omap@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, bcousson@baylibre.com,
peter.ujfalusi@ti.com, detheridge@ti.com
Subject: Re: [PATCH RFC 2/5] ASoC: tlv320aic31xx: Add codec driver to Makefile and Kconfig
Date: Mon, 3 Mar 2014 13:09:31 +0800 [thread overview]
Message-ID: <20140303050931.GQ2411@sirena.org.uk> (raw)
In-Reply-To: <e5ddd051ac319649d50da0da804750c1c6619edb.1393405575.git.jsarha@ti.com>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On Wed, Feb 26, 2014 at 11:14:26AM +0200, Jyri Sarha wrote:
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -74,6 +74,7 @@ config SND_SOC_ALL_CODECS
> select SND_SOC_TLV320AIC23 if I2C
> select SND_SOC_TLV320AIC26 if SPI_MASTER
> select SND_SOC_TLV320AIC32X4 if I2C
> + select SND_SOC_TLV320AIC31XX if I2C
> select SND_SOC_TLV320AIC3X if I2C
> select SND_SOC_TPA6130A2 if I2C
> select SND_SOC_TLV320DAC33 if I2C
Keep these files sorted and don't send the build infrastructure as a
separate patch unless the driver as a whole is split into multiple
patches - there is no value unless the driver is being built up over
several patches, it just raises a review question on the driver patch.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-03 5:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 9:14 [PATCH RFC 0/5] AM43xx-ePOS-EVM audio support with TLV320AIC31XX driver Jyri Sarha
2014-02-26 9:14 ` [PATCH RFC 1/5] ASoC: tlv320aic31xx: Add basic codec driver implementation Jyri Sarha
[not found] ` <73198e2f7aca0379abc596027d7d59ac250061c7.1393405575.git.jsarha-l0cyMroinI0@public.gmane.org>
2014-03-03 6:34 ` Mark Brown
2014-03-04 13:36 ` Jyri Sarha
2014-02-26 9:14 ` [PATCH RFC 2/5] ASoC: tlv320aic31xx: Add codec driver to Makefile and Kconfig Jyri Sarha
2014-02-27 14:11 ` Peter Ujfalusi
2014-03-03 5:09 ` Mark Brown [this message]
2014-02-26 9:14 ` [PATCH RFC 3/5] ASoC: tlv320aic31xx: Add DT binding document Jyri Sarha
2014-03-03 6:38 ` Mark Brown
2014-02-26 9:14 ` [PATCH RFC 4/5] ASoC: davinci-evm: Add AM43xx-EPOS-EVM audio support Jyri Sarha
2014-02-26 9:14 ` [PATCH RFC 5/5] ASoC: davinci: Add SND_AM43XX_SOC_EPOS_EVM build option Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303050931.GQ2411@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bcousson@baylibre.com \
--cc=detheridge@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jsarha@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox