From: Mark Brown <broonie@kernel.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: linux-omap@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, bcousson@baylibre.com,
peter.ujfalusi@ti.com, detheridge@ti.com
Subject: Re: [PATCH RFC 3/5] ASoC: tlv320aic31xx: Add DT binding document
Date: Mon, 3 Mar 2014 14:38:19 +0800 [thread overview]
Message-ID: <20140303063819.GS2411@sirena.org.uk> (raw)
In-Reply-To: <a72a69de5c86ee9e0931bac8d42cd72e4bee1a6b.1393405575.git.jsarha@ti.com>
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
On Wed, Feb 26, 2014 at 11:14:27AM +0200, Jyri Sarha wrote:
> +- ai31xx-micbias-vg - MicBias Voltage required.
> + 1 - MICBIAS output is powered to 2.0V,
> + 2 - MICBIAS output is powered to 2.5V,
> + 3 - MICBIAS output is connected to AVDD,
> + If this node is not mentioned or if the value is incorrect, then MicBias
> + is powered down.
Please provide defines for these as part of the binding. It's not clear
to me why leaving the micbias powered down is a sane default, it'll only
be powered up if it's connected to something and used which doesn't seem
altogether sane. I'd suggest picking 2.0V (the lowest voltage so least
likely to cause damage).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-03 6:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 9:14 [PATCH RFC 0/5] AM43xx-ePOS-EVM audio support with TLV320AIC31XX driver Jyri Sarha
2014-02-26 9:14 ` [PATCH RFC 1/5] ASoC: tlv320aic31xx: Add basic codec driver implementation Jyri Sarha
[not found] ` <73198e2f7aca0379abc596027d7d59ac250061c7.1393405575.git.jsarha-l0cyMroinI0@public.gmane.org>
2014-03-03 6:34 ` Mark Brown
2014-03-04 13:36 ` Jyri Sarha
2014-02-26 9:14 ` [PATCH RFC 2/5] ASoC: tlv320aic31xx: Add codec driver to Makefile and Kconfig Jyri Sarha
2014-02-27 14:11 ` Peter Ujfalusi
2014-03-03 5:09 ` Mark Brown
2014-02-26 9:14 ` [PATCH RFC 3/5] ASoC: tlv320aic31xx: Add DT binding document Jyri Sarha
2014-03-03 6:38 ` Mark Brown [this message]
2014-02-26 9:14 ` [PATCH RFC 4/5] ASoC: davinci-evm: Add AM43xx-EPOS-EVM audio support Jyri Sarha
2014-02-26 9:14 ` [PATCH RFC 5/5] ASoC: davinci: Add SND_AM43XX_SOC_EPOS_EVM build option Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303063819.GS2411@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bcousson@baylibre.com \
--cc=detheridge@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jsarha@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox