Re: [PATCH 1/3] ASoC: omap-abe-twl6040: No need to register DMIC routes seperatly

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1217 bytes --]

On Mon, Mar 10, 2014 at 12:29:33PM +0100, Lars-Peter Clausen wrote:
> On 03/10/2014 12:05 PM, Mark Brown wrote:

> >The only driver that I can think of which did anything like what you
> >describe was smdk-wm8580 and that was still only using one component,
> >it's just that Jassi preferred to split the input and output paths since
> >the DAIs were separate on the CODEC and he felt that was clearer.  It
> >didn't make any practical difference, it certainly wasn't due to startup
> >ordering.

> Take a look at e.g. omap/rx51.c it's doing what I'm describing and I
> presume it does this for the reasons I described.

Oh, rx51 is just generally fun - I'd be a bit surprised if it still
works.  It's actually the out of ASoC probe stuff that's causing
problems there, it was trying to do multi-component prior that being
supported.

> But it doesn't really matter. The important thing about this series
> is that card level DAPM elements and controls should be registered
> with the card not the CODEC and I think we can agree on that one.

Right, it's mostly just an alarm bell for review (I'd not looked at the
series yet, I tend to defer things until the people working on the
driver have had a chance to look).

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]