* [PATCH 1/2] ASoC: fsl_spdif: Fix incorrect usage of regmap_read()
@ 2014-05-06 8:41 Nicolin Chen
2014-05-12 22:11 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Nicolin Chen @ 2014-05-06 8:41 UTC (permalink / raw)
To: broonie; +Cc: tiwai, alsa-devel, lgirdwood
We should not copy the return value into this val since it's supposed to
get the value of the register not the success result of regmap_read().
Thus fix it.
Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com>
---
sound/soc/fsl/fsl_spdif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index b912d45..9ea2dd4 100644
--- a/sound/soc/fsl/fsl_spdif.c
+++ b/sound/soc/fsl/fsl_spdif.c
@@ -762,7 +762,7 @@ static int fsl_spdif_vbit_get(struct snd_kcontrol *kcontrol,
struct regmap *regmap = spdif_priv->regmap;
u32 val;
- val = regmap_read(regmap, REG_SPDIF_SIS, &val);
+ regmap_read(regmap, REG_SPDIF_SIS, &val);
ucontrol->value.integer.value[0] = (val & INT_VAL_NOGOOD) != 0;
regmap_write(regmap, REG_SPDIF_SIC, INT_VAL_NOGOOD);
--
1.8.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] ASoC: fsl_spdif: Fix incorrect usage of regmap_read()
2014-05-06 8:41 [PATCH 1/2] ASoC: fsl_spdif: Fix incorrect usage of regmap_read() Nicolin Chen
@ 2014-05-12 22:11 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-05-12 22:11 UTC (permalink / raw)
To: Nicolin Chen; +Cc: tiwai, alsa-devel, lgirdwood
[-- Attachment #1.1: Type: text/plain, Size: 243 bytes --]
On Tue, May 06, 2014 at 04:41:39PM +0800, Nicolin Chen wrote:
> We should not copy the return value into this val since it's supposed to
> get the value of the register not the success result of regmap_read().
> Thus fix it.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-12 22:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-06 8:41 [PATCH 1/2] ASoC: fsl_spdif: Fix incorrect usage of regmap_read() Nicolin Chen
2014-05-12 22:11 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox