Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: ASoC: Fix WM9713 mic 2 preamp volume
@ 2014-05-15 19:50 Matt Reimer
  2014-05-17 14:52 ` Charles Keepax
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Reimer @ 2014-05-15 19:50 UTC (permalink / raw)
  To: Alsa-devel; +Cc: Matt Reimer

Fix WM9713's mic 2 preamp volume. The previous definition specified
the Mic A pre-amp input select bits (aka "Mic A Source") instead.

Signed-off-by: Matt Reimer <mreimer@sdgsystems.com>
---
 sound/soc/codecs/wm9713.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/wm9713.c b/sound/soc/codecs/wm9713.c
index acea892..5f69b52 100644
--- a/sound/soc/codecs/wm9713.c
+++ b/sound/soc/codecs/wm9713.c
@@ -134,7 +134,7 @@ SOC_DOUBLE_TLV("PCM Playback Volume", AC97_PHONE, 8, 0, 31, 1, main_tlv),
 SOC_SINGLE_TLV("Mic 1 Volume", AC97_MIC, 8, 31, 1, main_tlv),
 SOC_SINGLE_TLV("Mic 2 Volume", AC97_MIC, 0, 31, 1, main_tlv),
 SOC_SINGLE_TLV("Mic 1 Preamp Volume", AC97_3D_CONTROL, 10, 3, 0, mic_tlv),
-SOC_SINGLE_TLV("Mic 2 Preamp Volume", AC97_3D_CONTROL, 12, 3, 0, mic_tlv),
+SOC_SINGLE_TLV("Mic 2 Preamp Volume", AC97_3D_CONTROL, 8, 3, 0, mic_tlv),
 
 SOC_SINGLE("Mic Boost (+20dB) Switch", AC97_LINE, 5, 1, 0),
 SOC_SINGLE("Mic Headphone Mixer Volume", AC97_LINE, 0, 7, 1),
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: ASoC: Fix WM9713 mic 2 preamp volume
  2014-05-15 19:50 [PATCH] ALSA: ASoC: Fix WM9713 mic 2 preamp volume Matt Reimer
@ 2014-05-17 14:52 ` Charles Keepax
  0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2014-05-17 14:52 UTC (permalink / raw)
  To: Matt Reimer, broonie; +Cc: Alsa-devel, patches, lgirdwood

On Thu, May 15, 2014 at 12:50:25PM -0700, Matt Reimer wrote:
> Fix WM9713's mic 2 preamp volume. The previous definition specified
> the Mic A pre-amp input select bits (aka "Mic A Source") instead.
> 
> Signed-off-by: Matt Reimer <mreimer@sdgsystems.com>
> ---

Change looks good, but remember to CC the maintainers on patches.

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-17 14:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-15 19:50 [PATCH] ALSA: ASoC: Fix WM9713 mic 2 preamp volume Matt Reimer
2014-05-17 14:52 ` Charles Keepax

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox