From: Vinod Koul <vinod.koul@intel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Kp Jeeja <jeeja.kp@intel.com>,
alsa-devel@alsa-project.org, broonie@kernel.org,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
lgirdwood@gmail.com
Subject: Re: [PATCH 2/2] ASoC: dapm: Add a helper to get the platform for DAPM kcontrol
Date: Mon, 26 May 2014 21:53:45 +0530 [thread overview]
Message-ID: <20140526162345.GG21128@intel.com> (raw)
In-Reply-To: <5383419F.9040105@metafoo.de>
On Mon, May 26, 2014 at 03:29:03PM +0200, Lars-Peter Clausen wrote:
> On 05/26/2014 02:08 PM, Vinod Koul wrote:
> [...]
> >+ * snd_soc_dapm_kcontrol_platform() - Returns the platform associated to a kcontrol
> >+ * @kcontrol: The kcontrol
> >+ */
> >+struct snd_soc_platform *snd_soc_dapm_kcontrol_platform(
> >+ struct snd_kcontrol *kcontrol)
> >+{
> >+ return dapm_kcontrol_get_wlist(kcontrol)->widgets[0]->platform;
> >+}
> >+EXPORT_SYMBOL_GPL(snd_soc_dapm_kcontrol_platform);
>
> This conflicts with the series that moves DAPM support to the
> component level [1].
Thanks for the pointer, has this series been merged?
Dont see it in topic/core in Mark's tree.
I will take a look but fwiw this statement is not entirely true in the cover
letter of patch:
"This will allow any component to have DAPM widgets and routes, which was
previously only possible for CODECs, and will allow any component to have DAPM
widgets with controls (i.e. Mixers and MUXs), which was previously only possible
for CODECs"
I am already running a system which models platform and has Mixers,
Muxes and works fine (tested on 3.10 and 3.14).
Few bits of code is in RFC I sent earlier and will post these in detail over
next few weeks
>
> - Lars
>
> [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2014-May/076718.html
>
--
~Vinod
next prev parent reply other threads:[~2014-05-26 16:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 12:08 [PATCH 1/2] ASoC: add api for dapm kcontrol configiuration Vinod Koul
2014-05-26 12:08 ` [PATCH 2/2] ASoC: dapm: Add a helper to get the platform for DAPM kcontrol Vinod Koul
2014-05-26 12:44 ` Jarkko Nikula
2014-05-26 12:51 ` Vinod Koul
2014-05-26 14:29 ` Mark Brown
2014-05-26 13:29 ` Lars-Peter Clausen
2014-05-26 16:23 ` Vinod Koul [this message]
2014-05-26 16:52 ` Lars-Peter Clausen
2014-05-26 16:47 ` Vinod Koul
2014-05-26 18:07 ` Lars-Peter Clausen
2014-05-26 18:54 ` Mark Brown
2014-05-26 13:26 ` [PATCH 1/2] ASoC: add api for dapm kcontrol configiuration Lars-Peter Clausen
2014-05-26 15:05 ` Mark Brown
2014-05-26 16:18 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526162345.GG21128@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=subhransu.s.prusty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox