From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: vinod.koul@intel.com, alsa-devel@alsa-project.org,
Lars-Peter Clausen <lars@metafoo.de>,
lgirdwood@gmail.com
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Add merrifield machine driver
Date: Sun, 17 Aug 2014 19:50:28 +0530 [thread overview]
Message-ID: <20140817142023.GA12530@vinod.koul@linux.intel.com> (raw)
In-Reply-To: <20140812214822.GB17528@sirena.org.uk>
On Tue, Aug 12, 2014 at 10:48:22PM +0100, Mark Brown wrote:
> On Tue, Aug 12, 2014 at 11:36:09AM +0530, Subhransu S. Prusty wrote:
> > On Tue, Jul 29, 2014 at 08:50:43PM +0100, Mark Brown wrote:
> > > On Thu, Jul 17, 2014 at 05:43:45PM +0530, Subhransu S. Prusty wrote:
>
> > > > + /* Force enable VMID to avoid cold latency constraints */
> > > > + snd_soc_dapm_force_enable_pin(&card->dapm, "VMID");
> > > > + snd_soc_dapm_sync(&card->dapm);
>
> > > This looks like you're open coding a version of wm8994_vmid_mode().
> > > Though that might need some tuning for systems that really have no
> > > single ended outputs.
>
> > VMID has a larget settling time. Keep it ON here to avoid the delay. Any
> > better way of doing this?
>
> Look at what wm8994_vmid_mode() does...
If I understand correctly need to move this enabling/disabling of VMID
to wm8994_vmid_mode().
--
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2014-08-17 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 12:13 [PATCH] ASoC: Intel: Add merrifield machine driver Subhransu S. Prusty
2014-07-29 19:50 ` Mark Brown
2014-08-12 6:06 ` Subhransu S. Prusty
2014-08-12 6:06 ` [alsa-devel] " Subhransu S. Prusty
2014-08-12 21:48 ` Mark Brown
2014-08-17 14:20 ` Subhransu S. Prusty [this message]
2014-08-17 14:57 ` Mark Brown
2014-08-18 3:59 ` Subhransu S. Prusty
2014-08-18 3:59 ` [alsa-devel] " Subhransu S. Prusty
2014-08-17 14:20 ` Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140817142023.GA12530@vinod.koul@linux.intel.com \
--to=subhransu.s.prusty@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox