Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: vinod.koul@intel.com, alsa-devel@alsa-project.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	lgirdwood@gmail.com
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Add merrifield machine driver
Date: Mon, 18 Aug 2014 09:29:55 +0530	[thread overview]
Message-ID: <20140818035951.GA13863@vinod.koul@linux.intel.com> (raw)
In-Reply-To: <20140817145750.GP14537@sirena.org.uk>

On Sun, Aug 17, 2014 at 09:57:50AM -0500, Mark Brown wrote:
> On Sun, Aug 17, 2014 at 07:50:28PM +0530, Subhransu S. Prusty wrote:
> > On Tue, Aug 12, 2014 at 10:48:22PM +0100, Mark Brown wrote:
> 
> > > Look at what wm8994_vmid_mode() does...
> 
> > If I understand correctly need to move this enabling/disabling of VMID
> > to wm8994_vmid_mode(). 
> 
> No, it's exactly what wm8994_vmid_mode() is there to do already -
> putting the device into WM8994_VMID_FORCE forces VMID on.

wm8994_vmid_mode() looks to be storing the mode in context and but it's
not applied. It's applied on VMID event.

-- 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2014-08-18  4:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17 12:13 [PATCH] ASoC: Intel: Add merrifield machine driver Subhransu S. Prusty
2014-07-29 19:50 ` Mark Brown
2014-08-12  6:06   ` [alsa-devel] " Subhransu S. Prusty
2014-08-12 21:48     ` Mark Brown
2014-08-17 14:20       ` [alsa-devel] " Subhransu S. Prusty
2014-08-17 14:57         ` Mark Brown
2014-08-18  3:59           ` Subhransu S. Prusty
2014-08-18  3:59           ` Subhransu S. Prusty [this message]
2014-08-17 14:20       ` Subhransu S. Prusty
2014-08-12  6:06   ` Subhransu S. Prusty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140818035951.GA13863@vinod.koul@linux.intel.com \
    --to=subhransu.s.prusty@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox