From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, subhransu.s.prusty@intel.com,
lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: Intel: Add Merrifield machine driver
Date: Mon, 3 Nov 2014 21:28:56 +0530 [thread overview]
Message-ID: <20141103155855.GA1870@intel.com> (raw)
In-Reply-To: <20141103120750.GD3815@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 821 bytes --]
On Mon, Nov 03, 2014 at 12:07:50PM +0000, Mark Brown wrote:
> On Mon, Nov 03, 2014 at 10:31:58AM +0530, Vinod Koul wrote:
> > On Fri, Oct 31, 2014 at 05:11:27PM +0000, Mark Brown wrote:
>
> > > > + snd_jack_set_key(ctx->jack.jack, SND_JACK_BTN_1, KEY_MEDIA);
> > > > + snd_jack_set_key(ctx->jack.jack, SND_JACK_BTN_0, KEY_MEDIA);
>
> > > Two buttons both reporting the same key? Might be worth a comment.
>
> > Okay loooking back I am not sure why we added two here, let me check and
> > clean this up.
>
> I was assuming it was because the tolerance desired on the button was
> wider than a single detection range on the device so this was ensuring
> that the button was reliably detected.
and thats is the changelog i found from our old kernel tree. So will add
this coment here...
--
~Vinod
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-11-03 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 10:11 [PATCH] ASoC: Intel: Add Merrifield machine driver Vinod Koul
2014-10-31 17:11 ` Mark Brown
2014-11-03 5:01 ` Vinod Koul
2014-11-03 12:07 ` Mark Brown
2014-11-03 15:58 ` Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-17 12:13 [PATCH] ASoC: Intel: Add merrifield " Subhransu S. Prusty
2014-07-29 19:50 ` Mark Brown
2014-08-12 6:06 ` [alsa-devel] " Subhransu S. Prusty
2014-08-12 21:48 ` Mark Brown
2014-08-17 14:20 ` [alsa-devel] " Subhransu S. Prusty
2014-08-17 14:57 ` Mark Brown
2014-08-18 3:59 ` Subhransu S. Prusty
2014-08-17 14:20 ` Subhransu S. Prusty
2014-08-12 6:06 ` Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103155855.GA1870@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=subhransu.s.prusty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox