* [PATCH] ASoC: wm5102: Initialize dac_comp_lock mutex
@ 2014-12-05 20:08 Mark Brown
2014-12-08 9:11 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2014-12-05 20:08 UTC (permalink / raw)
To: Charles Keepax, Liam Girdwood, Lars-Peter Clausen
Cc: alsa-devel, patches, Mark Brown
Commit d74bcaaeb6682 (ASoC: wm5102: Move ultrasonic response settings
lock to the driver level) created a driver local mutex for protecting
the ultrasonic response settings but neglected to initialize that mutex,
causing loud complaints from lockep and potential runtime failures. Fix
this by initializing the mutex.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/wm5102.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/wm5102.c b/sound/soc/codecs/wm5102.c
index 8c99b7cf47e0..f439ae052128 100644
--- a/sound/soc/codecs/wm5102.c
+++ b/sound/soc/codecs/wm5102.c
@@ -1900,6 +1900,8 @@ static int wm5102_probe(struct platform_device *pdev)
return -ENOMEM;
platform_set_drvdata(pdev, wm5102);
+ mutex_init(&arizona->dac_comp_lock);
+
wm5102->core.arizona = arizona;
wm5102->core.num_inputs = 6;
--
2.1.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: wm5102: Initialize dac_comp_lock mutex
2014-12-05 20:08 [PATCH] ASoC: wm5102: Initialize dac_comp_lock mutex Mark Brown
@ 2014-12-08 9:11 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2014-12-08 9:11 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Lars-Peter Clausen, Liam Girdwood, patches
On Fri, Dec 05, 2014 at 08:08:39PM +0000, Mark Brown wrote:
> Commit d74bcaaeb6682 (ASoC: wm5102: Move ultrasonic response settings
> lock to the driver level) created a driver local mutex for protecting
> the ultrasonic response settings but neglected to initialize that mutex,
> causing loud complaints from lockep and potential runtime failures. Fix
> this by initializing the mutex.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-08 9:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-05 20:08 [PATCH] ASoC: wm5102: Initialize dac_comp_lock mutex Mark Brown
2014-12-08 9:11 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox