Re: [PATCH v3 0/2] ALSA: jack: Refactoring for jack kctls

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1198 bytes --]

On Mon, Mar 23, 2015 at 05:38:22PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:

> > > Now the question is whether we need representing the same item for
> > > input jack, even though it's nothing but a place holder.  If we want
> > > to have consistency between input and kctl jack items, then yes.
> > > OTOH, we might want to drop buttons from kctls in anyway, so such a
> > > consistency has no importance.  Then we may just ignore phantom jacks
> > > for input jacks but create only phatom jack kctls, too, either by
> > > adding a new flag to indicate that, or let type=0 behaving like that.

> > I'm not sure I see the relevancy of buttons here?

> Well, you pointed that buttons are needed only for input devices, that
> implicitly means that we don't need to create kctls for buttons.

OK, right - if we had a jack that was button only and didn't have any
capability for detecting accessories.  That'd be a bit odd though.

> That is, it's not guaranteed that all jack items have to be present in
> as both input and kctl.  Following this logic, we may make phantom
> jacks only appearing in kctls but not in input.

Right, I understood that bit - I was just confused about the buttons.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]