From: Mark Brown <broonie@kernel.org>
To: Bard Liao <bardliao@realtek.com>
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
lars@metafoo.de, zhengxing@rock-chips.com, yang.a.fang@intel.com,
lgirdwood@gmail.com, john.lin@realtek.com,
koro.chen@mediatek.com, flove@realtek.com
Subject: Re: [PATCH 4/6] ASoC: rt5645: add device tree support
Date: Fri, 1 May 2015 17:32:47 +0100 [thread overview]
Message-ID: <20150501163247.GC22845@sirena.org.uk> (raw)
In-Reply-To: <1430389127-24609-4-git-send-email-bardliao@realtek.com>
[-- Attachment #1.1: Type: text/plain, Size: 854 bytes --]
On Thu, Apr 30, 2015 at 06:18:45PM +0800, Bard Liao wrote:
> +- realtek,dmic-en : Boolean. Indicate DMIC is used.
Why is this in DT as opposed to being configured by the DAPM routing or
something - what is the concrete effect of this? Also...
> +- realtek,dmic1-data-pin
> +- realtek,dmic2-data-pin
> + Indicate which pin is used for each DMIC.
...should it be combined with these (eg, if one of these properties is
specified should that imply that DMIC is enabled)? We should also have
something saying what the value for these properties is.
> +- realtek,en-jd-func
> + Boolean. Indicate if codec IRQ is used or not. It is usually used for JD
> + and/or headset button detection.
I'm not sure I understand what this is for? I'd expect that the
interrupt would be used if specified, though if a GPIO is specified I
guess that'd override it.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-05-01 16:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 10:18 [PATCH 1/6] ASoC: rt5645: remove RT5645_I2S_BCLK_MS1 control Bard Liao
2015-04-30 10:18 ` [PATCH 2/6] ASoC: rt5645: fix PLL source register definitions Bard Liao
2015-04-30 10:18 ` [PATCH 3/6] ASoC: rt5645: add TDM slot control into dapm route Bard Liao
2015-04-30 10:18 ` [PATCH 4/6] ASoC: rt5645: add device tree support Bard Liao
2015-05-01 16:32 ` Mark Brown [this message]
2015-05-04 5:21 ` Bard Liao
2015-05-04 11:59 ` Mark Brown
2015-05-05 5:59 ` Bard Liao
2015-04-30 10:18 ` [PATCH 5/6] ASoC: rt5645: fix wrong mask for button report Bard Liao
2015-05-01 16:34 ` Mark Brown
2015-04-30 10:18 ` [PATCH 6/6] ASoC: rt5645: make volume TLV closer to reality Bard Liao
2015-05-01 16:35 ` [PATCH 1/6] ASoC: rt5645: remove RT5645_I2S_BCLK_MS1 control Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501163247.GC22845@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=john.lin@realtek.com \
--cc=koro.chen@mediatek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=yang.a.fang@intel.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox