From: Mark Brown <broonie@kernel.org>
To: Bard Liao <bardliao@realtek.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"zhengxing@rock-chips.com" <zhengxing@rock-chips.com>,
"yang.a.fang@intel.com" <yang.a.fang@intel.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
John Lin <john.lin@realtek.com>,
"koro.chen@mediatek.com" <koro.chen@mediatek.com>,
Flove <flove@realtek.com>
Subject: Re: [PATCH 4/6] ASoC: rt5645: add device tree support
Date: Mon, 4 May 2015 12:59:07 +0100 [thread overview]
Message-ID: <20150504115907.GG15510@sirena.org.uk> (raw)
In-Reply-To: <ABFD875FF5FB574BA706497D987D48D701066F9B@RTITMBSV03.realtek.com.tw>
[-- Attachment #1.1: Type: text/plain, Size: 812 bytes --]
On Mon, May 04, 2015 at 05:21:59AM +0000, Bard Liao wrote:
> > > + Boolean. Indicate if codec IRQ is used or not. It is usually used
> > > +for JD
> > > + and/or headset button detection.
> > I'm not sure I understand what this is for? I'd expect that the interrupt
> > would be used if specified, though if a GPIO is specified I guess that'd
> > override it.
> It is for codec IRQ though it is called en-jd-func. rt5645 IRQ is not
> for JD only but also other functions (like button detection). Another
> thing is that a separate CPU pin is used for JD IRQ in some HW
> design. It means some HW design use their own JD function. That's
> what hp-det-gpio for.
I'm still not clear here - why is there a need for a separate flag over
just specifying the additional GPIO/interrupt to use for this function?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-05-04 13:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 10:18 [PATCH 1/6] ASoC: rt5645: remove RT5645_I2S_BCLK_MS1 control Bard Liao
2015-04-30 10:18 ` [PATCH 2/6] ASoC: rt5645: fix PLL source register definitions Bard Liao
2015-04-30 10:18 ` [PATCH 3/6] ASoC: rt5645: add TDM slot control into dapm route Bard Liao
2015-04-30 10:18 ` [PATCH 4/6] ASoC: rt5645: add device tree support Bard Liao
2015-05-01 16:32 ` Mark Brown
2015-05-04 5:21 ` Bard Liao
2015-05-04 11:59 ` Mark Brown [this message]
2015-05-05 5:59 ` Bard Liao
2015-04-30 10:18 ` [PATCH 5/6] ASoC: rt5645: fix wrong mask for button report Bard Liao
2015-05-01 16:34 ` Mark Brown
2015-04-30 10:18 ` [PATCH 6/6] ASoC: rt5645: make volume TLV closer to reality Bard Liao
2015-05-01 16:35 ` [PATCH 1/6] ASoC: rt5645: remove RT5645_I2S_BCLK_MS1 control Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150504115907.GG15510@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=john.lin@realtek.com \
--cc=koro.chen@mediatek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=yang.a.fang@intel.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox