From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: wm_adsp: Dump DSP_SCRATCH1 on DSP shutdown
Date: Thu, 28 May 2015 14:57:51 +0100 [thread overview]
Message-ID: <20150528135751.GV21577@sirena.org.uk> (raw)
In-Reply-To: <1432820714-31850-1-git-send-email-rf@opensource.wolfsonmicro.com>
[-- Attachment #1.1: Type: text/plain, Size: 539 bytes --]
On Thu, May 28, 2015 at 02:45:14PM +0100, Richard Fitzgerald wrote:
> +#define ADSP2_SCRATCH0 0x40
> +#define ADSP2_SCRATCH1 0x41
> +#define ADSP2_SCRATCH2 0x42
> +#define ADSP2_SCRATCH3 0x43
May as well dump the other scratches while you're at it?
> + unsigned int scratch1 = 0xFFFFFFFF;
Why is this being initialized?
> - adsp_dbg(dsp, "Shutdown complete\n");
> + adsp_info(dsp, "Shutdown complete (SCRATCH1:0x%x)\n", scratch1);
That seems a bit loud for a diagnostic message, why raise the severity?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-05-28 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 13:45 [PATCH] ASoC: wm_adsp: Dump DSP_SCRATCH1 on DSP shutdown Richard Fitzgerald
2015-05-28 13:57 ` Mark Brown [this message]
2015-05-28 14:24 ` Richard Fitzgerald
2015-05-28 14:37 ` Mark Brown
2015-05-28 16:13 ` Richard Fitzgerald
2015-05-28 19:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528135751.GV21577@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox