From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: wm_adsp: Dump DSP_SCRATCH1 on DSP shutdown
Date: Thu, 28 May 2015 17:13:13 +0100 [thread overview]
Message-ID: <20150528161313.GB19558@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20150528143724.GY21577@sirena.org.uk>
On Thu, May 28, 2015 at 03:37:24PM +0100, Mark Brown wrote:
> On Thu, May 28, 2015 at 03:24:39PM +0100, Richard Fitzgerald wrote:
> > On Thu, May 28, 2015 at 02:57:51PM +0100, Mark Brown wrote:
>
> > > > - adsp_dbg(dsp, "Shutdown complete\n");
> > > > + adsp_info(dsp, "Shutdown complete (SCRATCH1:0x%x)\n", scratch1);
>
> > > That seems a bit loud for a diagnostic message, why raise the severity?
>
> > It's a diagnostic of the firmware, not the driver, and we can't assume that
> > people trying to use a firmware have the ability to build and flash a kernel
> > with a debug version of the driver
>
> The default is that dev_dbg() is available in dmesg but not on the
> console which usually seems like a reasonable balance for this sort of
> thing - it's there if people want it but not included in the default
> logging.
What you're describing seems to be the default for dev_info().
For me I don't get any dev_dbg() output in the dmesg log unless the source
file has a #define DEBUG at the top.
next prev parent reply other threads:[~2015-05-28 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 13:45 [PATCH] ASoC: wm_adsp: Dump DSP_SCRATCH1 on DSP shutdown Richard Fitzgerald
2015-05-28 13:57 ` Mark Brown
2015-05-28 14:24 ` Richard Fitzgerald
2015-05-28 14:37 ` Mark Brown
2015-05-28 16:13 ` Richard Fitzgerald [this message]
2015-05-28 19:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528161313.GB19558@opensource.wolfsonmicro.com \
--to=rf@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox