From: Mark Brown <broonie@kernel.org>
To: Jie Yang <yang.jie@intel.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
vivian.zhang@intel.com, liam.r.girdwood@intel.com
Subject: Re: [PATCH] ASoC: add config to enable/disable asoc compress
Date: Tue, 2 Jun 2015 11:58:14 +0100 [thread overview]
Message-ID: <20150602105814.GM14071@sirena.org.uk> (raw)
In-Reply-To: <1432992511-864-1-git-send-email-yang.jie@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 249 bytes --]
On Sat, May 30, 2015 at 09:28:31PM +0800, Jie Yang wrote:
> +ifneq ($(CONFIG_SND_SOC_COMPRESS),)
> +snd-soc-core-objs += soc-compress.o
> +endif
If you want to make this optional why not make it a module so that the
Makefile looks more idiomatic?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-06-02 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 13:28 [PATCH] ASoC: add config to enable/disable asoc compress Jie Yang
2015-06-02 10:58 ` Mark Brown [this message]
2015-06-02 12:01 ` Takashi Iwai
2015-06-03 5:30 ` Jie, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602105814.GM14071@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=liam.r.girdwood@intel.com \
--cc=tiwai@suse.de \
--cc=vivian.zhang@intel.com \
--cc=yang.jie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox