Re: [PATCH] ASoC: add config to enable/disable asoc compress

[Takashi Iwai <tiwai@suse.de>]

At Tue, 2 Jun 2015 11:58:14 +0100,
Mark Brown wrote:
> 
> On Sat, May 30, 2015 at 09:28:31PM +0800, Jie Yang wrote:
> 
> > +ifneq ($(CONFIG_SND_SOC_COMPRESS),)
> > +snd-soc-core-objs += soc-compress.o
> > +endif
> 
> If you want to make this optional why not make it a module so that the
> Makefile looks more idiomatic?

Only about Makefile, it can be simplified like

snd-soc-core-$(CONFIG_SND_SOC_COMPRESS) += soc-compress.o

But I agree with Mark.  It would make more sense to split a module, as
soc-compress.c isn't so small.  For a small object, it's often better
to keep in, as a module consumes more memory (it needs a page size).
For a large size object, it's worth to consider to split.


Takashi