[asoc:topic/zx 2/4] sound/soc/zte/zx296702-i2s.c:358:27: sparse: symbol 'zx_i2s_dai' was not declared. Should it be static?

[asoc:topic/zx 2/4] sound/soc/zte/zx296702-i2s.c:358:27: sparse: symbol 'zx_i2s_dai' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/zx
head:   dc772a4cf76113d7269e4fb1c45e5d85c0cf458e
commit: e5d4cd87800ce12c356e7eb571e565e839ab3a90 [2/4] ASoC: zx: Add ZTE zx296702 I2S DAI driver
reproduce:
  # apt-get install sparse
  git checkout e5d4cd87800ce12c356e7eb571e565e839ab3a90
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> sound/soc/zte/zx296702-i2s.c:358:27: sparse: symbol 'zx_i2s_dai' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[PATCH asoc] ASoC: zx: zx_i2s_dai can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 zx296702-i2s.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/zte/zx296702-i2s.c b/sound/soc/zte/zx296702-i2s.c
index cf6005c..472fde3 100644
--- a/sound/soc/zte/zx296702-i2s.c
+++ b/sound/soc/zte/zx296702-i2s.c
@@ -355,7 +355,7 @@ static const struct snd_soc_component_driver zx_i2s_component = {
 	.name			= "zx-i2s",
 };
 
-struct snd_soc_dai_driver zx_i2s_dai = {
+static struct snd_soc_dai_driver zx_i2s_dai = {
 	.name	= "zx-i2s-dai",
 	.id	= 0,
 	.probe	= zx_i2s_dai_probe,

Re: [PATCH asoc] ASoC: zx: zx_i2s_dai can be static

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

On Thu, Jun 04, 2015 at 09:00:50PM +0800, kbuild test robot wrote:
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]