Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Mats Karrman <mats.dev.list@gmail.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
	Mark Brown <broonie@kernel.org>,
	linux-rt-users <linux-rt-users@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	rostedt@goodmis.org, John Kacur <jkacur@redhat.com>,
	Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>,
	alsa-devel@alsa-project.org, Jie Yang <yang.jie@intel.com>
Subject: [PATCH v2] ASoC: Intel: sst: use ; instead of , at the of a C statement
Date: Thu, 11 Jun 2015 15:14:34 +0200	[thread overview]
Message-ID: <20150611131434.GI16115@linutronix.de> (raw)
In-Reply-To: <55798759.8000607@gmail.com>

This was spotted by Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>
while he tried to compile a -RT kernel with this driver enabled.
"make C=2" would also warn about this. This is is based on his patch.

Reported-by: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
* Mats Karrman | 2015-06-11 15:04:25 [+0200]:

>>+	sst_shim_write64(shim, SST_IMRX, shim_regs->imrx):
>Don't you mean ';' and not ':'?
Interresting, yes I do. Thanks.

 sound/soc/intel/atom/sst/sst.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c
index 96c2e420cce6..a4b458e77089 100644
--- a/sound/soc/intel/atom/sst/sst.c
+++ b/sound/soc/intel/atom/sst/sst.c
@@ -368,8 +368,8 @@ static inline void sst_restore_shim64(struct intel_sst_drv *ctx,
 	 * initialize by FW or driver when firmware is loaded
 	 */
 	spin_lock_irqsave(&ctx->ipc_spin_lock, irq_flags);
-	sst_shim_write64(shim, SST_IMRX, shim_regs->imrx),
-	sst_shim_write64(shim, SST_CSR, shim_regs->csr),
+	sst_shim_write64(shim, SST_IMRX, shim_regs->imrx);
+	sst_shim_write64(shim, SST_CSR, shim_regs->csr);
 	spin_unlock_irqrestore(&ctx->ipc_spin_lock, irq_flags);
 }
 
-- 
2.1.4

  reply	other threads:[~2015-06-11 13:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150519213923.GA26363@linutronix.de>
     [not found] ` <55623BC2.80307@localhost>
2015-06-11 12:22   ` [PATCH] ASoC: Intel: sst: use ; instead of , at the of a C statement Sebastian Andrzej Siewior
2015-06-11 13:04     ` Mats Karrman
2015-06-11 13:14       ` Sebastian Andrzej Siewior [this message]
2015-06-12  7:22         ` [PATCH v2] " Vinod Koul
2015-06-12 10:37         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150611131434.GI16115@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mats.dev.list@gmail.com \
    --cc=nando@ccrma.Stanford.EDU \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=vinod.koul@intel.com \
    --cc=yang.jie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox