* [PATCH] ASoC: Intel: sst: use ; instead of , at the of a C statement [not found] ` <55623BC2.80307@localhost> @ 2015-06-11 12:22 ` Sebastian Andrzej Siewior 2015-06-11 13:04 ` Mats Karrman 0 siblings, 1 reply; 5+ messages in thread From: Sebastian Andrzej Siewior @ 2015-06-11 12:22 UTC (permalink / raw) To: Vinod Koul, Mark Brown Cc: linux-rt-users, LKML, Thomas Gleixner, rostedt, John Kacur, Fernando Lopez-Lezcano, alsa-devel, Jie Yang This was spotted by Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> while he tried to compile a -RT kernel with this driver enabled. "make C=2" would also warn about this. This is is based on his patch. Reported-by: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- sound/soc/intel/atom/sst/sst.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c index 96c2e420cce6..b0c3e0e56302 100644 --- a/sound/soc/intel/atom/sst/sst.c +++ b/sound/soc/intel/atom/sst/sst.c @@ -368,8 +368,8 @@ static inline void sst_restore_shim64(struct intel_sst_drv *ctx, * initialize by FW or driver when firmware is loaded */ spin_lock_irqsave(&ctx->ipc_spin_lock, irq_flags); - sst_shim_write64(shim, SST_IMRX, shim_regs->imrx), - sst_shim_write64(shim, SST_CSR, shim_regs->csr), + sst_shim_write64(shim, SST_IMRX, shim_regs->imrx): + sst_shim_write64(shim, SST_CSR, shim_regs->csr); spin_unlock_irqrestore(&ctx->ipc_spin_lock, irq_flags); } -- 2.1.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Intel: sst: use ; instead of , at the of a C statement 2015-06-11 12:22 ` [PATCH] ASoC: Intel: sst: use ; instead of , at the of a C statement Sebastian Andrzej Siewior @ 2015-06-11 13:04 ` Mats Karrman 2015-06-11 13:14 ` [PATCH v2] " Sebastian Andrzej Siewior 0 siblings, 1 reply; 5+ messages in thread From: Mats Karrman @ 2015-06-11 13:04 UTC (permalink / raw) To: Sebastian Andrzej Siewior, Vinod Koul, Mark Brown Cc: linux-rt-users, LKML, Thomas Gleixner, rostedt, John Kacur, Fernando Lopez-Lezcano, alsa-devel, Jie Yang On 2015-06-11 14:22, Sebastian Andrzej Siewior wrote: > This was spotted by Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> > while he tried to compile a -RT kernel with this driver enabled. > "make C=2" would also warn about this. This is is based on his patch. > > Reported-by: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > sound/soc/intel/atom/sst/sst.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c > index 96c2e420cce6..b0c3e0e56302 100644 > --- a/sound/soc/intel/atom/sst/sst.c > +++ b/sound/soc/intel/atom/sst/sst.c > @@ -368,8 +368,8 @@ static inline void sst_restore_shim64(struct intel_sst_drv *ctx, > * initialize by FW or driver when firmware is loaded > */ > spin_lock_irqsave(&ctx->ipc_spin_lock, irq_flags); > - sst_shim_write64(shim, SST_IMRX, shim_regs->imrx), > - sst_shim_write64(shim, SST_CSR, shim_regs->csr), > + sst_shim_write64(shim, SST_IMRX, shim_regs->imrx): Don't you mean ';' and not ':'? > + sst_shim_write64(shim, SST_CSR, shim_regs->csr); > spin_unlock_irqrestore(&ctx->ipc_spin_lock, irq_flags); > } > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ASoC: Intel: sst: use ; instead of , at the of a C statement 2015-06-11 13:04 ` Mats Karrman @ 2015-06-11 13:14 ` Sebastian Andrzej Siewior 2015-06-12 7:22 ` Vinod Koul 2015-06-12 10:37 ` Mark Brown 0 siblings, 2 replies; 5+ messages in thread From: Sebastian Andrzej Siewior @ 2015-06-11 13:14 UTC (permalink / raw) To: Mats Karrman Cc: Vinod Koul, Mark Brown, linux-rt-users, LKML, Thomas Gleixner, rostedt, John Kacur, Fernando Lopez-Lezcano, alsa-devel, Jie Yang This was spotted by Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> while he tried to compile a -RT kernel with this driver enabled. "make C=2" would also warn about this. This is is based on his patch. Reported-by: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- * Mats Karrman | 2015-06-11 15:04:25 [+0200]: >>+ sst_shim_write64(shim, SST_IMRX, shim_regs->imrx): >Don't you mean ';' and not ':'? Interresting, yes I do. Thanks. sound/soc/intel/atom/sst/sst.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c index 96c2e420cce6..a4b458e77089 100644 --- a/sound/soc/intel/atom/sst/sst.c +++ b/sound/soc/intel/atom/sst/sst.c @@ -368,8 +368,8 @@ static inline void sst_restore_shim64(struct intel_sst_drv *ctx, * initialize by FW or driver when firmware is loaded */ spin_lock_irqsave(&ctx->ipc_spin_lock, irq_flags); - sst_shim_write64(shim, SST_IMRX, shim_regs->imrx), - sst_shim_write64(shim, SST_CSR, shim_regs->csr), + sst_shim_write64(shim, SST_IMRX, shim_regs->imrx); + sst_shim_write64(shim, SST_CSR, shim_regs->csr); spin_unlock_irqrestore(&ctx->ipc_spin_lock, irq_flags); } -- 2.1.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ASoC: Intel: sst: use ; instead of , at the of a C statement 2015-06-11 13:14 ` [PATCH v2] " Sebastian Andrzej Siewior @ 2015-06-12 7:22 ` Vinod Koul 2015-06-12 10:37 ` Mark Brown 1 sibling, 0 replies; 5+ messages in thread From: Vinod Koul @ 2015-06-12 7:22 UTC (permalink / raw) To: Sebastian Andrzej Siewior Cc: Mats Karrman, Mark Brown, linux-rt-users, LKML, Thomas Gleixner, rostedt, John Kacur, Fernando Lopez-Lezcano, alsa-devel, Jie Yang, patches.audio On Thu, Jun 11, 2015 at 03:14:34PM +0200, Sebastian Andrzej Siewior wrote: > This was spotted by Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> > while he tried to compile a -RT kernel with this driver enabled. > "make C=2" would also warn about this. This is is based on his patch. > > Reported-by: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: Vinod Koul <vinod.koul@intel.com> -- ~Vinod > --- > * Mats Karrman | 2015-06-11 15:04:25 [+0200]: > > >>+ sst_shim_write64(shim, SST_IMRX, shim_regs->imrx): > >Don't you mean ';' and not ':'? > Interresting, yes I do. Thanks. > > sound/soc/intel/atom/sst/sst.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c > index 96c2e420cce6..a4b458e77089 100644 > --- a/sound/soc/intel/atom/sst/sst.c > +++ b/sound/soc/intel/atom/sst/sst.c > @@ -368,8 +368,8 @@ static inline void sst_restore_shim64(struct intel_sst_drv *ctx, > * initialize by FW or driver when firmware is loaded > */ > spin_lock_irqsave(&ctx->ipc_spin_lock, irq_flags); > - sst_shim_write64(shim, SST_IMRX, shim_regs->imrx), > - sst_shim_write64(shim, SST_CSR, shim_regs->csr), > + sst_shim_write64(shim, SST_IMRX, shim_regs->imrx); > + sst_shim_write64(shim, SST_CSR, shim_regs->csr); > spin_unlock_irqrestore(&ctx->ipc_spin_lock, irq_flags); > } > > -- > 2.1.4 -- ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ASoC: Intel: sst: use ; instead of , at the of a C statement 2015-06-11 13:14 ` [PATCH v2] " Sebastian Andrzej Siewior 2015-06-12 7:22 ` Vinod Koul @ 2015-06-12 10:37 ` Mark Brown 1 sibling, 0 replies; 5+ messages in thread From: Mark Brown @ 2015-06-12 10:37 UTC (permalink / raw) To: Sebastian Andrzej Siewior Cc: Mats Karrman, Vinod Koul, linux-rt-users, LKML, Thomas Gleixner, rostedt, John Kacur, Fernando Lopez-Lezcano, alsa-devel, Jie Yang [-- Attachment #1: Type: text/plain, Size: 304 bytes --] On Thu, Jun 11, 2015 at 03:14:34PM +0200, Sebastian Andrzej Siewior wrote: > This was spotted by Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> > while he tried to compile a -RT kernel with this driver enabled. > "make C=2" would also warn about this. This is is based on his patch. Applied, thanks. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-12 10:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150519213923.GA26363@linutronix.de>
[not found] ` <55623BC2.80307@localhost>
2015-06-11 12:22 ` [PATCH] ASoC: Intel: sst: use ; instead of , at the of a C statement Sebastian Andrzej Siewior
2015-06-11 13:04 ` Mats Karrman
2015-06-11 13:14 ` [PATCH v2] " Sebastian Andrzej Siewior
2015-06-12 7:22 ` Vinod Koul
2015-06-12 10:37 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox