public inbox for alsa-devel@alsa-project.org
 help / color / mirror / Atom feed
* [PATCH v2] ASoC: fsl-sai: add 32 bit word length support
@ 2015-08-10  2:43 Zidan Wang
  2015-08-10 20:24 ` Timur Tabi
  0 siblings, 1 reply; 3+ messages in thread
From: Zidan Wang @ 2015-08-10  2:43 UTC (permalink / raw)
  To: nicoleotsuka; +Cc: alsa-devel, timur, Zidan Wang, Xiubo.Lee, tiwai, broonie

Add 32 bit word length support. There are no code changes required
in the SAI driver since it has already wirten the word width to the
corresponding register.

Signed-off-by: Zidan Wang <zidan.wang@freescale.com>
---
 sound/soc/fsl/fsl_sai.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/soc/fsl/fsl_sai.h b/sound/soc/fsl/fsl_sai.h
index 0662809..40280ce 100644
--- a/sound/soc/fsl/fsl_sai.h
+++ b/sound/soc/fsl/fsl_sai.h
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2013 Freescale Semiconductor, Inc.
+ * Copyright 2012-2015 Freescale Semiconductor, Inc.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
@@ -13,7 +13,8 @@
 
 #define FSL_SAI_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |\
 			 SNDRV_PCM_FMTBIT_S20_3LE |\
-			 SNDRV_PCM_FMTBIT_S24_LE)
+			 SNDRV_PCM_FMTBIT_S24_LE |\
+			 SNDRV_PCM_FMTBIT_S32_LE)
 
 /* SAI Register Map Register */
 #define FSL_SAI_TCSR	0x00 /* SAI Transmit Control */
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ASoC: fsl-sai: add 32 bit word length support
  2015-08-10  2:43 [PATCH v2] ASoC: fsl-sai: add 32 bit word length support Zidan Wang
@ 2015-08-10 20:24 ` Timur Tabi
  2015-08-11  1:56   ` Zidan Wang
  0 siblings, 1 reply; 3+ messages in thread
From: Timur Tabi @ 2015-08-10 20:24 UTC (permalink / raw)
  To: Zidan Wang, nicoleotsuka; +Cc: alsa-devel, broonie, tiwai, Xiubo.Lee

On 08/09/2015 09:43 PM, Zidan Wang wrote:
> - * Copyright 2012-2013 Freescale Semiconductor, Inc.
> + * Copyright 2012-2015 Freescale Semiconductor, Inc.

The change you made does not warrant a new copyright year.  You didn't 
add any copyrightable content.

Besides, Freescale's policy is to not update copyright years in patches. 
  I know, because I worked with the legal department to set that policy 
back in 2012.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ASoC: fsl-sai: add 32 bit word length support
  2015-08-10 20:24 ` Timur Tabi
@ 2015-08-11  1:56   ` Zidan Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Zidan Wang @ 2015-08-11  1:56 UTC (permalink / raw)
  To: Timur Tabi; +Cc: alsa-devel, Xiubo.Lee, tiwai, nicoleotsuka, broonie

On Mon, Aug 10, 2015 at 03:24:46PM -0500, Timur Tabi wrote:
> On 08/09/2015 09:43 PM, Zidan Wang wrote:
> >- * Copyright 2012-2013 Freescale Semiconductor, Inc.
> >+ * Copyright 2012-2015 Freescale Semiconductor, Inc.
> 
> The change you made does not warrant a new copyright year.  You
> didn't add any copyrightable content.
> 
> Besides, Freescale's policy is to not update copyright years in
> patches.  I know, because I worked with the legal department to set
> that policy back in 2012.
I don't know that policy. I will remove the copyright update. Thanks.

Best Regards,
Zidan Wang

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-11  3:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-10  2:43 [PATCH v2] ASoC: fsl-sai: add 32 bit word length support Zidan Wang
2015-08-10 20:24 ` Timur Tabi
2015-08-11  1:56   ` Zidan Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox