From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org,
Omair M Abdullah <omair.m.abdullah@intel.com>,
Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH 1/3] ASoC: Intel: Skylake: fix missing machine device creation
Date: Mon, 2 Nov 2015 12:07:27 +0000 [thread overview]
Message-ID: <20151102120727.GD20228@sirena.org.uk> (raw)
In-Reply-To: <20151102101108.GL21326@localhost>
[-- Attachment #1.1: Type: text/plain, Size: 1019 bytes --]
On Mon, Nov 02, 2015 at 03:41:08PM +0530, Vinod Koul wrote:
> On Sun, Nov 01, 2015 at 11:54:38AM +0900, Mark Brown wrote:
> > > The UEFI BIOS does not create a machine entry for Linux devices
> > > so add a table style machine registration to fix this missing
> > > entry
> > How does this relate to the existing sst_acpi code? This might be
> > clearer with a user...
> It is similar but sst_machines structure is entirely different. In Skylake
> case we only need machine entry name and rest of the information is coming
So what exactly is the "machine entry name" supposed to be here and why
don't we use any board specific information?
> from topology manifest data. I will try to move this as well to topology
> data later, but for now on upstream to get audio out from boards I need this
> patch :)
I'm not sure I entirely believe that this is going to work well in
practice TBH.
> I am not sure I follow the comment on user, the SKL driver here is user in
> this
There are no machines defined for this.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-11-02 12:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 15:04 [PATCH 0/3] ASoC: Intel: Skylake: Some more fixes Vinod Koul
2015-10-30 15:04 ` [PATCH 1/3] ASoC: Intel: Skylake: fix missing machine device creation Vinod Koul
2015-11-01 2:54 ` Mark Brown
2015-11-02 10:11 ` Vinod Koul
2015-11-02 12:07 ` Mark Brown [this message]
2015-11-02 15:32 ` Vinod Koul
2015-11-03 11:24 ` Mark Brown
2015-11-03 12:29 ` Keyon
2015-11-03 17:58 ` Vinod Koul
2015-11-03 17:57 ` Vinod Koul
2015-11-04 14:29 ` Mark Brown
2015-11-04 16:07 ` Vinod Koul
2015-10-30 15:04 ` [PATCH 2/3] ASoC: Intel: Skylake: Fix to cleanup if skl_sst_dsp_init fails Vinod Koul
2015-11-02 10:39 ` Applied "ASoC: Intel: Skylake: Fix to cleanup if skl_sst_dsp_init fails" to the asoc tree Mark Brown
2015-10-30 15:04 ` [PATCH 3/3] ASoC: Intel: Skylake: Fix substream dereference before check Vinod Koul
2015-11-02 10:39 ` Applied "ASoC: Intel: Skylake: Fix substream dereference before check" to the asoc tree Mark Brown
2015-10-30 15:04 ` [PATCH 0/3] ASoC: Intel: Skylake: Some more fixes Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102120727.GD20228@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=omair.m.abdullah@intel.com \
--cc=patches.audio@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox