From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org,
Omair M Abdullah <omair.m.abdullah@intel.com>,
Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH 1/3] ASoC: Intel: Skylake: fix missing machine device creation
Date: Wed, 4 Nov 2015 14:29:58 +0000 [thread overview]
Message-ID: <20151104142958.GG1717@sirena.org.uk> (raw)
In-Reply-To: <20151103175708.GH12910@localhost>
[-- Attachment #1.1: Type: text/plain, Size: 755 bytes --]
On Tue, Nov 03, 2015 at 11:27:08PM +0530, Vinod Koul wrote:
> On Tue, Nov 03, 2015 at 11:24:58AM +0000, Mark Brown wrote:
> > I'm having a hard time seeing the difference between this and what's
> > going on in sst-acpi. They seem to be doing the same thing in slightly
> > different ways, they both match tables of CODEC IDs to machine driver
> > names with the distinction being that this doesn't provide a firmware
> > filename whereas sst-acpi does but the mechanics of mapping a CODEC to a
> > machine driver seem otherwise the same.
> I don't disagree with your observation, the code does same stuff and only
> difference is the data we require here, so commonizing becomes tricky
The only difference in data appears to be a firmware file name?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-11-04 14:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 15:04 [PATCH 0/3] ASoC: Intel: Skylake: Some more fixes Vinod Koul
2015-10-30 15:04 ` [PATCH 1/3] ASoC: Intel: Skylake: fix missing machine device creation Vinod Koul
2015-11-01 2:54 ` Mark Brown
2015-11-02 10:11 ` Vinod Koul
2015-11-02 12:07 ` Mark Brown
2015-11-02 15:32 ` Vinod Koul
2015-11-03 11:24 ` Mark Brown
2015-11-03 12:29 ` Keyon
2015-11-03 17:58 ` Vinod Koul
2015-11-03 17:57 ` Vinod Koul
2015-11-04 14:29 ` Mark Brown [this message]
2015-11-04 16:07 ` Vinod Koul
2015-10-30 15:04 ` [PATCH 2/3] ASoC: Intel: Skylake: Fix to cleanup if skl_sst_dsp_init fails Vinod Koul
2015-11-02 10:39 ` Applied "ASoC: Intel: Skylake: Fix to cleanup if skl_sst_dsp_init fails" to the asoc tree Mark Brown
2015-10-30 15:04 ` [PATCH 3/3] ASoC: Intel: Skylake: Fix substream dereference before check Vinod Koul
2015-11-02 10:39 ` Applied "ASoC: Intel: Skylake: Fix substream dereference before check" to the asoc tree Mark Brown
2015-10-30 15:04 ` [PATCH 0/3] ASoC: Intel: Skylake: Some more fixes Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104142958.GG1717@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=omair.m.abdullah@intel.com \
--cc=patches.audio@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox