Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Cc: alsa-devel@alsa-project.org, mengdong.lin@linux.intel.com,
	Takashi Iwai <tiwai@suse.de>,
	mengdong.lin@intel.com,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	broonie@kernel.org
Subject: Re: [PATCH] topology: Include <linux/types.h> in API header file
Date: Tue, 10 Nov 2015 17:59:39 +0530	[thread overview]
Message-ID: <20151110122939.GE25173@localhost> (raw)
In-Reply-To: <20151109140425.GA5572@subhransu-desktop>

On Mon, Nov 09, 2015 at 07:34:29PM +0530, Subhransu S. Prusty wrote:
> On Fri, Nov 06, 2015 at 02:57:17PM +0000, Liam Girdwood wrote:
> > On Fri, 2015-11-06 at 15:40 +0100, Takashi Iwai wrote:
> > > On Fri, 06 Nov 2015 15:37:27 +0100,
> > > Liam Girdwood wrote:
> > > > 
> > > > 
> > > > >From 568f769269122e90fceee605a98a1a526db2b3d4 Mon Sep 17 00:00:00 2001
> > > > From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
> > > > Date: Fri, 6 Nov 2015 14:30:36 +0000
> > > > Subject: [PATCH] topology: remove little endian type from userspace header.
> > > > 
> > > > Use a generic unsigned long long for formats instead of an ABI endian
> > > > specific __le64 type.
> > > 
> > > Or use uint64_t instead.  This is the standard definition of 64bit
> > > integer.  I thought we already include stdint.h somewhere, but you can
> > > included it there again to be sure, too.
> > > 
> > 
> > I didn't see stdint.h so used unsigned long long on the first patch. The
> > patch below fixes this though :-
> > 
> > From 52d3023e482ac856692bf27819d97d9a037a055b Mon Sep 17 00:00:00 2001
> > From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
> > Date: Fri, 6 Nov 2015 14:30:36 +0000
> > Subject: [PATCH] topology: remove little endian type from userspace header.
> > 
> > Use a generic uint64_t for formats instead of an ABI endian specific
> > __le64 type.
> 
> Tested and it works fine.

Hi Takashi,

Is this fix okay, was this applied ?

-- 
~Vinod

  reply	other threads:[~2015-11-10 12:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06 12:39 [PATCH] topology: Include <linux/types.h> in API header file mengdong.lin
2015-11-06 12:59 ` Takashi Iwai
2015-11-06 13:31   ` Vinod Koul
2015-11-06 13:33     ` Takashi Iwai
2015-11-06 14:37       ` Liam Girdwood
2015-11-06 14:40         ` Takashi Iwai
2015-11-06 14:57           ` Liam Girdwood
2015-11-09 14:04             ` Subhransu S. Prusty
2015-11-10 12:29               ` Vinod Koul [this message]
2015-11-10 12:29                 ` Jaroslav Kysela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151110122939.GE25173@localhost \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=mengdong.lin@intel.com \
    --cc=mengdong.lin@linux.intel.com \
    --cc=subhransu.s.prusty@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox