Re: [PATCH] topology: Include <linux/types.h> in API header file

[Jaroslav Kysela <perex@perex.cz>]

Dne 10.11.2015 v 13:29 Vinod Koul napsal(a):
> On Mon, Nov 09, 2015 at 07:34:29PM +0530, Subhransu S. Prusty wrote:
>> On Fri, Nov 06, 2015 at 02:57:17PM +0000, Liam Girdwood wrote:
>>> On Fri, 2015-11-06 at 15:40 +0100, Takashi Iwai wrote:
>>>> On Fri, 06 Nov 2015 15:37:27 +0100,
>>>> Liam Girdwood wrote:
>>>>>
>>>>>
>>>>> >From 568f769269122e90fceee605a98a1a526db2b3d4 Mon Sep 17 00:00:00 2001
>>>>> From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
>>>>> Date: Fri, 6 Nov 2015 14:30:36 +0000
>>>>> Subject: [PATCH] topology: remove little endian type from userspace header.
>>>>>
>>>>> Use a generic unsigned long long for formats instead of an ABI endian
>>>>> specific __le64 type.
>>>>
>>>> Or use uint64_t instead.  This is the standard definition of 64bit
>>>> integer.  I thought we already include stdint.h somewhere, but you can
>>>> included it there again to be sure, too.
>>>>
>>>
>>> I didn't see stdint.h so used unsigned long long on the first patch. The
>>> patch below fixes this though :-
>>>
>>> From 52d3023e482ac856692bf27819d97d9a037a055b Mon Sep 17 00:00:00 2001
>>> From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
>>> Date: Fri, 6 Nov 2015 14:30:36 +0000
>>> Subject: [PATCH] topology: remove little endian type from userspace header.
>>>
>>> Use a generic uint64_t for formats instead of an ABI endian specific
>>> __le64 type.
>>
>> Tested and it works fine.
> 
> Hi Takashi,
> 
> Is this fix okay, was this applied ?
> 

Yes, it's in alsa-lib-1.1.0, too:

http://git.alsa-project.org/?p=alsa-lib.git;a=summary

					Jaroslav


-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.