Re: [PATCH 1/2] ASoC: imx-wm8958: add imx-wm8958 machine driver

[Zidan Wang <zidan.wang@freescale.com>]

On Tue, Dec 08, 2015 at 12:47:13PM +0000, Mark Brown wrote:
> On Tue, Dec 08, 2015 at 05:40:13PM +0800, Zidan Wang wrote:
> 
> > + - aifx-format             : set format for aifx, such as "i2s", "left_j",
> > +			     "dsp_a", "dsp_b".
> 
> > + - aifx-bitclock-master    : If present, aifx wroks as bit clock master.
> > +			     Otherwise, aifx works as bit clock slave.
> 
> > + - aifx-frame-master	   : If present, aifx wroks as frame clock master.
> > +			     Otherwise, aifx works as frame clock slave.
> 
> > + - aifx-bitclock-inversion : If present, bit clock will invert polarity.
> 
> > + - aifx-frame-inversion	   : If present, frame clock will invert polarity.
> 
> > + - aifx-continuous-clock   : If present, bit clock will be continuous.
> > +			     Otherwise, dai bit clocks can be be gated
> > +			     (disabled) when the dai is not sending or
> > +			     receiving PCM data in a frame.
> 
> Why are these selectable in the machine driver?
I have tested and found that sai<->aif1 can support "i2s" "left_j"
"dsp_a" "dsp_b" format, and can support cpu dai master and slave
mode. But I haven't tested voice dai and bt dai because of hardware
limitation. I just using sai<->aif2 to test aif2.

So I want to configure the dai format from device tree. And there is
a help function snd_soc_of_parse_daifmt for me to do this, so I add
these selectable to the machine driver.

> 
> > +		model = "wm8960-audio";
> 
> Cut'n'paste error here.

it should be "wm8958-audio", i will modify it.


Best Regards,
Zidan Wang